[turbofan] Sparse representation for state values

src/compiler/common-operator.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/common-operator.h"
 
 #include "src/assembler.h"
 #include "src/base/lazy-instance.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator.h"
 #include "src/handles-inl.h"
 #include "src/zone/zone.h"
 
+namespace std {
+template <typename T, typename S>
+ostream& operator<<(ostream& o, const pair<T, S>& p) {
+  return o << "(" << p.first << ", " << p.second << ")";
+}
+}
+
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 std::ostream& operator<<(std::ostream& os, BranchHint hint) {
   switch (hint) {
     case BranchHint::kNone:
       return os << "None";
     case BranchHint::kTrue:
       return os << "True";
@@ skipping 206 matching lines @@
 }
 
 OsrGuardType OsrGuardTypeOf(Operator const* op) {
   DCHECK_EQ(IrOpcode::kOsrGuard, op->opcode());
   return OpParameter<OsrGuardType>(op);
 }
 
 ZoneVector<MachineType> const* MachineTypesOf(Operator const* op) {
   DCHECK(op->opcode() == IrOpcode::kTypedObjectState ||
          op->opcode() == IrOpcode::kTypedStateValues);
+
+  if (op->opcode() == IrOpcode::kTypedStateValues) {
+    const ZoneVector<MachineType>* types =
+        OpParameter<std::pair<const ZoneVector<MachineType>*, uint32_t>>(op)
+            .first;

[Jarin, 2016/11/16 15:32:42]

This is confusing - where is 'types' used?

Should not it be returned here?

[Leszek Swirski, 2016/11/17 09:23:04]

Whoops, yes it should. Bad rebase. I think the below return happened to still
work because const ZoneVector<MachineType>* is the first field of the pair
anyway, but yeah, this should be a return.

+  }
   return OpParameter<const ZoneVector<MachineType>*>(op);
 }
 
 #define CACHED_OP_LIST(V)                                                     \
   V(Dead, Operator::kFoldable, 0, 0, 0, 1, 1, 1)                              \
   V(IfTrue, Operator::kKontrol, 0, 0, 1, 0, 0, 1)                             \
   V(IfFalse, Operator::kKontrol, 0, 0, 1, 0, 0, 1)                            \
   V(IfSuccess, Operator::kKontrol, 0, 0, 1, 0, 0, 1)                          \
   V(IfException, Operator::kKontrol, 0, 1, 1, 1, 1, 1)                        \
   V(IfDefault, Operator::kKontrol, 0, 0, 1, 0, 0, 1)                          \
@@ skipping 330 matching lines @@
               "Projection",           // name
               1, 0, 1, 1, 0, 0,       // counts,
               kIndex) {}              // parameter
   };
 #define CACHED_PROJECTION(index) \
   ProjectionOperator<index> kProjection##index##Operator;
   CACHED_PROJECTION_LIST(CACHED_PROJECTION)
 #undef CACHED_PROJECTION
 
   template <int kInputCount>
-  struct StateValuesOperator final : public Operator {
+  struct StateValuesOperator final : public Operator1<uint32_t> {
     StateValuesOperator()
-        : Operator(                           // --
-              IrOpcode::kStateValues,         // opcode
-              Operator::kPure,                // flags
-              "StateValues",                  // name
-              kInputCount, 0, 0, 1, 0, 0) {}  // counts
+        : Operator1<uint32_t>(             // --
+              IrOpcode::kStateValues,      // opcode
+              Operator::kPure,             // flags
+              "StateValues",               // name
+              kInputCount, 0, 0, 1, 0, 0,  // counts
+              0) {}                        // parameter
   };
 #define CACHED_STATE_VALUES(input_count) \
   StateValuesOperator<input_count> kStateValues##input_count##Operator;
   CACHED_STATE_VALUES_LIST(CACHED_STATE_VALUES)
 #undef CACHED_STATE_VALUES
 };
 
 
 static base::LazyInstance<CommonOperatorGlobalCache>::type kCache =
     LAZY_INSTANCE_INITIALIZER;
@@ skipping 385 matching lines @@
   switch (region_observability) {
     case RegionObservability::kObservable:
       return &cache_.kBeginRegionObservableOperator;
     case RegionObservability::kNotObservable:
       return &cache_.kBeginRegionNotObservableOperator;
   }
   UNREACHABLE();
   return nullptr;
 }
 
-const Operator* CommonOperatorBuilder::StateValues(int arguments) {
-  switch (arguments) {
+const Operator* CommonOperatorBuilder::StateValues(int arguments,
+                                                   uint32_t bitmask) {
+  if (bitmask == 0) {
+    switch (arguments) {
 #define CACHED_STATE_VALUES(arguments) \
   case arguments:                      \
     return &cache_.kStateValues##arguments##Operator;
-    CACHED_STATE_VALUES_LIST(CACHED_STATE_VALUES)
+      CACHED_STATE_VALUES_LIST(CACHED_STATE_VALUES)
 #undef CACHED_STATE_VALUES
-    default:
-      break;
+      default:
+        break;
+    }
   }
+
   // Uncached.
-  return new (zone()) Operator(                 // --
+  return new (zone()) Operator1<uint32_t>(      // --
       IrOpcode::kStateValues, Operator::kPure,  // opcode
       "StateValues",                            // name
-      arguments, 0, 0, 1, 0, 0);                // counts
+      arguments, 0, 0, 1, 0, 0,                 // counts
+      bitmask);                                 // parameter
 }
 
 const Operator* CommonOperatorBuilder::TypedStateValues(
-    const ZoneVector<MachineType>* types) {
-  return new (zone()) Operator1<const ZoneVector<MachineType>*>(  // --
-      IrOpcode::kTypedStateValues, Operator::kPure,               // opcode
-      "TypedStateValues",                                         // name
-      static_cast<int>(types->size()), 0, 0, 1, 0, 0,             // counts
-      types);                                                     // parameter
+    const ZoneVector<MachineType>* types, uint32_t bitmask) {
+  return new (zone())
+      Operator1<std::pair<const ZoneVector<MachineType>*, uint32_t>>(  // --
+          IrOpcode::kTypedStateValues, Operator::kPure,                // opcode
+          "TypedStateValues",                                          // name
+          static_cast<int>(types->size()), 0, 0, 1, 0, 0,              // counts
+          std::make_pair(types, bitmask));  // parameters
 }
 
 const Operator* CommonOperatorBuilder::ObjectState(int pointer_slots) {
   return new (zone()) Operator1<int>(           // --
       IrOpcode::kObjectState, Operator::kPure,  // opcode
       "ObjectState",                            // name
       pointer_slots, 0, 0, 1, 0, 0,             // counts
       pointer_slots);                           // parameter
 }
 
@@ skipping 99 matching lines @@
 CommonOperatorBuilder::CreateFrameStateFunctionInfo(
     FrameStateType type, int parameter_count, int local_count,
     Handle<SharedFunctionInfo> shared_info) {
   return new (zone()->New(sizeof(FrameStateFunctionInfo)))
       FrameStateFunctionInfo(type, parameter_count, local_count, shared_info);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8