Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2509593003: Loading: factor out common functionalities for memory cache testing (Closed)

Created:
4 years, 1 month ago by Takashi Toyoshima
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: factor out common functionalities for memory cache testing Before splitting resource type specific memory cache tests from CachingCorrectnessTest, factor out common functionalities for memory cache testing so that we can use it from multiple test files. BUG=655920 Committed: https://crrev.com/aca85fb7b0661acec32e99688fc99f6de63b6e69 Cr-Commit-Position: refs/heads/master@{#435133}

Patch Set 1 #

Total comments: 6

Patch Set 2 : review #8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -706 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp View 1 chunk +0 lines, -590 lines 0 comments Download
A + third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp View 20 chunks +36 lines, -115 lines 0 comments Download
A third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp View 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (16 generated)
Takashi Toyoshima
ptal
4 years, 1 month ago (2016-11-16 10:01:30 UTC) #5
hiroshige
lgtm with nits. https://codereview.chromium.org/2509593003/diff/1/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h File third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h (right): https://codereview.chromium.org/2509593003/diff/1/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h#newcode24 third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h:24: Resource* fetch(); Memo (not blocking this ...
4 years, 1 month ago (2016-11-17 06:24:38 UTC) #8
Takashi Toyoshima
https://codereview.chromium.org/2509593003/diff/1/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h File third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h (right): https://codereview.chromium.org/2509593003/diff/1/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h#newcode24 third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h:24: Resource* fetch(); OK, let me leave a TODO here. ...
4 years ago (2016-11-29 07:56:12 UTC) #9
Takashi Toyoshima
yhirano: ptal, this patch does not have any dependency now.
4 years ago (2016-11-29 07:56:33 UTC) #10
yhirano
lgtm
4 years ago (2016-11-29 08:25:44 UTC) #11
Takashi Toyoshima
+kouhei for BUILD.gn
4 years ago (2016-11-29 09:46:11 UTC) #15
kouhei (in TOK)
rslgtm
4 years ago (2016-11-30 01:40:52 UTC) #18
kouhei (in TOK)
On 2016/11/30 01:40:52, kouhei wrote: > rslgtm real lgtm
4 years ago (2016-11-30 01:41:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509593003/20001
4 years ago (2016-11-30 05:13:06 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 07:41:15 UTC) #25
commit-bot: I haz the power
4 years ago (2016-11-30 07:43:52 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aca85fb7b0661acec32e99688fc99f6de63b6e69
Cr-Commit-Position: refs/heads/master@{#435133}

Powered by Google App Engine
This is Rietveld 408576698