Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: third_party/WebKit/Source/core/css/ElementRuleCollector.cpp

Issue 2509593002: Implement ::placeholder CSS selector. (Closed)
Patch Set: Introduce PseudoType::PseudoPlaceholder Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
diff --git a/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp b/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
index c77c0da1d62db403fadcb59e1dff9bc28c9c21cd..a29b23c31bced68efcb50dc8f4d70953bf150076 100644
--- a/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
+++ b/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
@@ -196,6 +196,8 @@ void ElementRuleCollector::collectMatchingRules(
collectMatchingRulesForList(
matchRequest.ruleSet->shadowPseudoElementRules(pseudoId), cascadeOrder,
matchRequest);
+ collectMatchingRulesForList(matchRequest.ruleSet->placeholderPseudoRules(),
+ cascadeOrder, matchRequest);
rune 2016/11/21 08:52:33 This means we'll try to match ::placeholder rules
tkent 2016/11/21 09:23:39 Oh, that's right. Fixed.
}
if (element.isVTTElement())

Powered by Google App Engine
This is Rietveld 408576698