additional_compile_targets:all for ChromiumOS

additional_compile_targets:all for ChromiumOS

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.
Add '"additional_compile_targets": ["All"]' to GPU FYI
"Linux ChromiumOS Builder."

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/1290391b53c0574a7209d5d03d365a9b5a09ecf3
Cr-Commit-Position: refs/heads/master@{#432783}

[fjhenigman, 2016-11-16 04:02:11]

Description was changed from

==========
generate_buildbot_json: builders need properties

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.

BUG=chromium:665701
==========

to

==========
generate_buildbot_json: builders need properties

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[fjhenigman, 2016-11-16 04:04:17]

Description was changed from

==========
generate_buildbot_json: builders need properties

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
generate_buildbot_json: builders need properties

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[fjhenigman, 2016-11-16 04:04:17]

fjhenigman@chromium.org changed reviewers:
+ jmadill@chromium.org

[fjhenigman, 2016-11-16 04:07:04]

This what you had in mind Jamie?
After this, putting '"additional_compile_targets": ["All"]' into "Linux
ChromiumOS Builder" is another change.

[Jamie Madill, 2016-11-16 14:43:47]

Looks fine - can you actually put the change for ChromiumOS in this CL as well,
then run the generator? That way we can see if it works.

[fjhenigman, 2016-11-16 19:19:43]

On 2016/11/16 14:43:47, Jamie Madill wrote:
> Looks fine - can you actually put the change for ChromiumOS in this CL as
well,
> then run the generator? That way we can see if it works.

I've tested locally and it produces the desired json (by inspection, not
tested).
To me this seems like it should be two CLs, but if you disagree I'll defer.
I didn't upload the second CL because I don't know if that works, one CL
depending on another.  I've done it in gerrit before but I think it's different
here.

[Jamie Madill, 2016-11-16 19:31:12]

On 2016/11/16 19:19:43, fjhenigman wrote:
> On 2016/11/16 14:43:47, Jamie Madill wrote:
> > Looks fine - can you actually put the change for ChromiumOS in this CL as
> well,
> > then run the generator? That way we can see if it works.
> 
> I've tested locally and it produces the desired json (by inspection, not
> tested).
> To me this seems like it should be two CLs, but if you disagree I'll defer.
> I didn't upload the second CL because I don't know if that works, one CL
> depending on another.  I've done it in gerrit before but I think it's
different
> here.

yes, Chromium has a more single-CL ecosystem. Please make it one CL. Also it
would help test the CL more quickly.

[Jamie Madill, 2016-11-16 20:46:00]

jmadill@chromium.org changed reviewers:
+ kbr@chromium.org

[Jamie Madill, 2016-11-16 20:46:42]

LGTM, nice work Frank. Ken can you review this since you're an owner? This
should fix the problem of the waterfall bot only building 'aura_builder' on the
gpu.fyi version.

See the non-gpu.fyi version json file here:

https://cs.chromium.org/chromium/src/testing/buildbot/chromium.chromiumos.json

[fjhenigman, 2016-11-16 20:49:14]

Description was changed from

==========
generate_buildbot_json: builders need properties

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
additional_compile_targets:all for ChromiumOS

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[fjhenigman, 2016-11-16 20:49:39]

Description was changed from

==========
additional_compile_targets:all for ChromiumOS

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
additional_compile_targets:all for ChromiumOS

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.
Add '"additional_compile_targets": ["All"]' to GPU FYI
"Linux ChromiumOS Builder."

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-16 21:49:23]

Good work Frank. LGTM

[fjhenigman, 2016-11-16 22:03:18]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2016-11-16 22:04:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 22:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 22:55:55]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Ken Russell (switch to Gerrit), 2016-11-16 23:02:36]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-16 23:04:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 23:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 23:36:32]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Jamie Madill, 2016-11-16 23:51:43]

The CQ bit was checked by jmadill@chromium.org

[commit-bot: I haz the power, 2016-11-16 23:53:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-11-17 00:18:27]

On 2016/11/16 23:36:32, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

This net_unittests flakiness is filed as http://crbug.com/665686 .

[commit-bot: I haz the power, 2016-11-17 01:22:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:23:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)

[fjhenigman, 2016-11-17 04:49:48]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:50:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 06:22:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 06:26:42]

Description was changed from

==========
additional_compile_targets:all for ChromiumOS

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.
Add '"additional_compile_targets": ["All"]' to GPU FYI
"Linux ChromiumOS Builder."

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
additional_compile_targets:all for ChromiumOS

Change the waterfall 'builders' lists to dictionaries so we can specify
arbitrary stuff to come through in the generated json.
Add '"additional_compile_targets": ["All"]' to GPU FYI
"Linux ChromiumOS Builder."

BUG=chromium:665701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/1290391b53c0574a7209d5d03d365a9b5a09ecf3
Cr-Commit-Position: refs/heads/master@{#432783}
==========

[commit-bot: I haz the power, 2016-11-17 06:26:42]

Patchset 3 (id:??) landed as
https://crrev.com/1290391b53c0574a7209d5d03d365a9b5a09ecf3
Cr-Commit-Position: refs/heads/master@{#432783}