Do not add a Resource with DoNotBufferData policy to the memory cache

third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
     rights reserved.
     Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
@@ skipping 726 matching lines @@
                             << request.resourceRequest().url().elidedString();
 
   Resource* resource =
       factory.create(request.resourceRequest(), request.options(), charset);
   resource->setLinkPreload(request.isLinkPreload());
   if (request.forPreload()) {
     resource->setPreloadDiscoveryTime(request.preloadDiscoveryTime());
   }
   resource->setCacheIdentifier(cacheIdentifier);
 
   // Don't add main resource to cache to prevent reuse.

[hiroshige, 2016/11/16 06:34:58]

Please update the comment.

[yhirano, 2016/11/16 07:21:49]

Done.

-  if (factory.type() != Resource::MainResource)
+  if (factory.type() != Resource::MainResource &&
+      request.options().dataBufferingPolicy == BufferData)

[hiroshige, 2016/11/16 06:34:58]

optional: |request.options().dataBufferingPolicy != DoNotBufferData| might be
easier to read ("Add to memory cache, unless MainResource or DoNotBufferData").

[yhirano, 2016/11/16 07:21:49]

Done.

     memoryCache()->add(resource);
   return resource;
 }
 
 void ResourceFetcher::storeResourceTimingInitiatorInformation(
     Resource* resource) {
   const AtomicString& fetchInitiator = resource->options().initiatorInfo.name;
   if (fetchInitiator == FetchInitiatorTypeNames::internal)
     return;
 
@@ skipping 882 matching lines @@
   visitor->trace(m_context);
   visitor->trace(m_archive);
   visitor->trace(m_loaders);
   visitor->trace(m_nonBlockingLoaders);
   visitor->trace(m_documentResources);
   visitor->trace(m_preloads);
   visitor->trace(m_resourceTimingInfoMap);
 }
 
 }  // namespace blink