Prefer third_party version of jinja2

Prefer third_party version of jinja2

Change include path to check third_party before the system path when
including jinja2. This ensures that the version in third_party is used
instead of the system version, which might be older.

tbr=viettrungluu

[Nico, 2014-04-25 17:03:36]

lgtm, that looks like the correct fix to me. (Maybe explain the problem this is
solving in the CL description or in a comment down here; e.g. just by pasting
your stack).

Since this is breaking your build it's probably breaking someone else's too, so
I'd tbr=viettrungluu this and then fix eventual comments in a follow-up.

Thanks!

[eae, 2014-04-25 17:11:17]

Example failure

[59/8148] RULE Generating Mojo bindings from public/interfaces/shell/shell.mojom
FAILED: cd ../../mojo; python
../mojo/public/tools/bindings/mojom_bindings_generator.py
"public/interfaces/shell/shell.mojom" -d .. -o
"../out/Release/gen/mojo/public/interfaces/shell"
Traceback (most recent call last):
  File "../mojo/public/tools/bindings/mojom_bindings_generator.py",
line 150, in <module>
    sys.exit(Main())
  File "../mojo/public/tools/bindings/mojom_bindings_generator.py",
line 144, in Main
    ProcessFile(args, generator_modules, filename)
  File "../mojo/public/tools/bindings/mojom_bindings_generator.py",
line 114, in ProcessFile
    generator.GenerateFiles()
  File
"/usr/local/google2/projects/turblinken/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py",
line 219, in GenerateFiles
    self.Write(self.GenerateModuleHeader(), "%s.h" % self.module.name)
  File
"/usr/local/google2/projects/turblinken/src/mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py",
line 51, in GeneratorInternal
    filters=filters)
  File
"/usr/local/google2/projects/turblinken/src/mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py",
line 37, in ApplyTemplate
    jinja_env = jinja2.Environment(loader=loader, keep_trailing_newline=True)
TypeError: __init__() got an unexpected keyword argument 'keep_trailing_newline'
[59/8148] CXX obj/base/allocator/allocator.debugallocation_shim.o
ninja: build stopped: subcommand failed.

[eae, 2014-04-25 17:11:21]

The CQ bit was checked by eae@chromium.org

[eae, 2014-04-25 17:11:37]

Thanks Nico!

[viettrungluu, 2014-04-25 17:18:38]

The CQ bit was unchecked by viettrungluu@chromium.org

[viettrungluu, 2014-04-25 17:19:14]

Please do not commit this. I have a change for this that fixes it in the
preferred way: https://codereview.chromium.org/258733003/.

[viettrungluu, 2014-04-25 17:20:05]

On 2014/04/25 17:19:14, viettrungluu wrote:
> Please do not commit this. I have a change for this that fixes it in the
> preferred way: https://codereview.chromium.org/258733003/.

(For context: things under mojo/public are meant to be usable outside a Chromium
checkout.)

[Nico, 2014-04-25 17:24:11]

On Fri, Apr 25, 2014 at 10:20 AM,  <viettrungluu@chromium.org> wrote:
> On 2014/04/25 17:19:14, viettrungluu wrote:
>>
>> Please do not commit this. I have a change for this that fixes it in the
>> preferred way: https://codereview.chromium.org/258733003/.
>
>
> (For context: things under mojo/public are meant to be usable outside a
> Chromium checkout.)

Ah, that makes sense.

>
> https://codereview.chromium.org/250953003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.