Issue 250953002: Changing aura::test::EventGenerator to send events through EventSource instead of through EventProc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250953002: Changing aura::test::EventGenerator to send events through EventSource instead of through EventProc… (Closed)

Created:
6 years, 8 months ago by mfomitchev

Modified:
6 years, 8 months ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank

Base URL:
https://chromium.googlesource.com/chromium/src.git@get_event_source

Visibility:
Public.

More Reviews

Description

Changing aura::test::EventGenerator to send events through EventSource instead of through EventProcessor. This way EventRewriters get hit by the test event flow. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266358

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added WARN_UNUSED_RESULT #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
M	ui/aura/test/event_generator.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/events/event_source.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/events/test/events_test_utils.h	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	ui/events/test/events_test_utils.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

Cool! LGTM https://codereview.chromium.org/250953002/diff/1/ui/events/test/events_test_utils.h File ui/events/test/events_test_utils.h (right): https://codereview.chromium.org/250953002/diff/1/ui/events/test/events_test_utils.h#newcode68 ui/events/test/events_test_utils.h:68: EventDispatchDetails SendEventToProcessor(Event* event); Can you add a ...

6 years, 8 months ago (2014-04-25 17:31:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/250953002/20001

6 years, 8 months ago (2014-04-25 22:11:46 UTC) #4

Message was sent while issue was closed.

Change committed as 266358

Expand Messages | Collapse Messages