Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2509503002: Add config for ios-device-xcode-clang bot (Closed)

Created:
4 years, 1 month ago by smut
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add config for ios-device-xcode-clang bot And remove additional_compile_targets to match ios-simulator and ios-simulator-xcode-clang. BUG=661612 Committed: https://crrev.com/60835da990f9379e9208b257f30f0b56a2d722fc Cr-Commit-Position: refs/heads/master@{#432413}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ios/build/bots/chromium.mac/ios-device.json View 1 chunk +0 lines, -1 line 0 comments Download
A + ios/build/bots/chromium.mac/ios-device-xcode-clang.json View 2 chunks +3 lines, -3 lines 2 comments Download
M ios/build/bots/chromium.mac/ios-simulator-cronet.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
smut
4 years, 1 month ago (2016-11-16 00:14:58 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/2509503002/diff/1/ios/build/bots/chromium.mac/ios-device-xcode-clang.json File ios/build/bots/chromium.mac/ios-device-xcode-clang.json (right): https://codereview.chromium.org/2509503002/diff/1/ios/build/bots/chromium.mac/ios-device-xcode-clang.json#newcode3 ios/build/bots/chromium.mac/ios-device-xcode-clang.json:3: "sdefresne", awww ...
4 years, 1 month ago (2016-11-16 01:09:40 UTC) #4
smut
https://codereview.chromium.org/2509503002/diff/1/ios/build/bots/chromium.mac/ios-device-xcode-clang.json File ios/build/bots/chromium.mac/ios-device-xcode-clang.json (right): https://codereview.chromium.org/2509503002/diff/1/ios/build/bots/chromium.mac/ios-device-xcode-clang.json#newcode3 ios/build/bots/chromium.mac/ios-device-xcode-clang.json:3: "sdefresne", On 2016/11/16 01:09:40, Dirk Pranke wrote: > awww ...
4 years, 1 month ago (2016-11-16 01:12:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509503002/1
4 years, 1 month ago (2016-11-16 02:19:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 06:50:41 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:54:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60835da990f9379e9208b257f30f0b56a2d722fc
Cr-Commit-Position: refs/heads/master@{#432413}

Powered by Google App Engine
This is Rietveld 408576698