Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2509493003: Revert of [ios] Removed back-forward navigation API from CRWWebController. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] Removed back-forward navigation API from CRWWebController. (patchset #2 id:20001 of https://codereview.chromium.org/2499593003/ ) Reason for revert: Breaks upstream unit test. Original issue's description: > [ios] Removed back-forward navigation API from CRWWebController. > > NavigationManager API should be used for navigation instead. > > BUG=661316 > > Committed: https://crrev.com/f00c143bc322f36f5ff919620fd57b2e021a3262 > Cr-Commit-Position: refs/heads/master@{#432369} TBR=kkhorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661316 Committed: https://crrev.com/862c1088fa95986676931fcf7231fcbd6d182fe4 Cr-Commit-Position: refs/heads/master@{#432372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M ios/web/web_state/ui/crw_web_controller.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 3 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Eugene But (OOO till 7-30)
Created Revert of [ios] Removed back-forward navigation API from CRWWebController.
4 years, 1 month ago (2016-11-16 03:42:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509493003/1
4 years, 1 month ago (2016-11-16 03:43:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 03:46:41 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/862c1088fa95986676931fcf7231fcbd6d182fe4 Cr-Commit-Position: refs/heads/master@{#432372}
4 years, 1 month ago (2016-11-16 03:51:47 UTC) #6
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-16 14:52:04 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2505013002/ by eugenebut@chromium.org.

The reason for reverting is: Downstream tests were fixed. Relanding without
changes..

Powered by Google App Engine
This is Rietveld 408576698