Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2509483002: Fixed WebVR HTTP warning only rendering in the right eye (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
Reviewers:
mthiesse, bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed WebVR HTTP warning only rendering in the right eye BUG=389343 Committed: https://crrev.com/038c81ab311795eacbb747f7b83e303040c24c5d Cr-Commit-Position: refs/heads/master@{#432325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 3 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bajones
Issue was that we were clearing the canvas twice but disabling scissor testing on the ...
4 years, 1 month ago (2016-11-15 23:54:29 UTC) #2
mthiesse
lgtm
4 years, 1 month ago (2016-11-16 00:11:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509483002/1
4 years, 1 month ago (2016-11-16 00:16:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 00:47:38 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 00:51:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/038c81ab311795eacbb747f7b83e303040c24c5d
Cr-Commit-Position: refs/heads/master@{#432325}

Powered by Google App Engine
This is Rietveld 408576698