Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2509473002: MD CrOS - Fix indentation of network detail rows (VPN, wifi, etc.) (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
tdanderson, James Cook
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul, bruthig
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD CrOS - Fix indentation of network detail rows (VPN, wifi, etc.) BUG=663037 TBR=tdanderson@chromium.org Committed: https://crrev.com/d406e73ecf3323b0dfa3c085767b9893d7e25e93 Cr-Commit-Position: refs/heads/master@{#432338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Evan Stade
4 years, 1 month ago (2016-11-15 23:29:29 UTC) #2
James Cook
lgtm
4 years, 1 month ago (2016-11-15 23:38:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509473002/1
4 years, 1 month ago (2016-11-15 23:55:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509473002/1
4 years, 1 month ago (2016-11-15 23:56:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 01:28:28 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 01:34:27 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d406e73ecf3323b0dfa3c085767b9893d7e25e93
Cr-Commit-Position: refs/heads/master@{#432338}

Powered by Google App Engine
This is Rietveld 408576698