Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2509453002: When building app snapshots for the SDK, train dart2js on itself. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When building app snapshots for the SDK, train dart2js on itself. Don't train the analzyer on itself as this makes running the test suite slower. Disable code collection when generating an app snapshot. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/13ba4b271003a1784c1257bd84e87fcf56cb9bd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/bin/main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M utils/compiler/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
time ./tools/test.py -ax64 -mrelease --use-sdk --nobatch -cdart2js -rd8 corelib lib real 6m12.461s user 173m47.597s sys ...
4 years, 1 month ago (2016-11-15 22:46:39 UTC) #2
siva
lgtm
4 years, 1 month ago (2016-11-16 00:02:25 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-16 17:10:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13ba4b271003a1784c1257bd84e87fcf56cb9bd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698