Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2509443002: [ios] Adds a TestSigninResourceProvider to TestChromeBrowserProvider. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds a TestSigninResourceProvider to TestChromeBrowserProvider. Some unittests expect a non-NULL SigninResourceProvider, so this CL adds a test provider that returns empty images and dummy strings. BUG=665591 Committed: https://crrev.com/42e5307a4649baf9f82e03ca1b7138674f389741 Cr-Commit-Position: refs/heads/master@{#432461}

Patch Set 1 #

Patch Set 2 : Copyright. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/signin/test_signin_resources_provider.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/signin/test_signin_resources_provider.mm View 1 1 chunk +21 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.mm View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
rohitrao (ping after 24h)
4 years, 1 month ago (2016-11-15 21:52:05 UTC) #4
lpromero-g
lgtm
4 years, 1 month ago (2016-11-16 10:00:27 UTC) #9
bzanotti
lgtm
4 years, 1 month ago (2016-11-16 10:52:55 UTC) #10
lpromero
lgtm
4 years, 1 month ago (2016-11-16 10:54:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509443002/20001
4 years, 1 month ago (2016-11-16 11:03:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 11:45:04 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 11:46:48 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42e5307a4649baf9f82e03ca1b7138674f389741
Cr-Commit-Position: refs/heads/master@{#432461}

Powered by Google App Engine
This is Rietveld 408576698