Move enum MenuAnchorPosition to reduce deps on menu_item_view.h

ui/base/ui_base_types.h

Index: ui/base/ui_base_types.h
diff --git a/ui/base/ui_base_types.h b/ui/base/ui_base_types.h
index fc4ed95bab12ff8cab8604aaec797a02b548379a..d04b13462fa4346e4f40b8a85b06dd24d1f6259d 100644
--- a/ui/base/ui_base_types.h
+++ b/ui/base/ui_base_types.h
@@ -53,6 +53,20 @@ enum MenuSourceType {
 
 UI_BASE_EXPORT MenuSourceType GetMenuSourceTypeForEvent(const ui::Event& event);
 
+// Where a popup menu should be anchored to for non-RTL languages. The opposite
+// position will be used if base::i18n:IsRTL() is true. The BUBBLE flags are
+// used when the menu should get enclosed by a bubble. Note that BUBBLE flags
+// should only be used with menus which have no children.
+enum MenuAnchorPosition {

[sky, 2014/04/29 15:30:57]

I'm fine with moving MenuAnchorPosition, but it's view specific. Maybe
ui/views/controls/menu/menu_types.h.

[tapted, 2014/04/30 08:32:56]

Done.

+  MENU_ANCHOR_TOPLEFT,
+  MENU_ANCHOR_TOPRIGHT,
+  MENU_ANCHOR_BOTTOMCENTER,
+  MENU_ANCHOR_BUBBLE_LEFT,
+  MENU_ANCHOR_BUBBLE_RIGHT,
+  MENU_ANCHOR_BUBBLE_ABOVE,
+  MENU_ANCHOR_BUBBLE_BELOW
+};
+
 }  // namespace ui
 
 #endif  // UI_BASE_UI_BASE_TYPES_H_

[tapted, 2014/04/29 11:53:14]

<link to interesting file>