An isolate created with spawn function doesn't necessarily agree with its parent on the library pri…

An isolate created with spawn function doesn't necessarily agree with its parent on the library private keys.

(The long-standing issue that spawn function should use snapshots would also fix this.)

Encountered by the analyzer in https://codereview.chromium.org/2492933002/

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/12de13d1ae9dec5311157b74d7be5521dcdd7d87

[rmacnak, 2016-11-17 19:28:31]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-11-22 06:18:21]

lgtm

https://codereview.chromium.org/2509413002/diff/1/tests/isolate/send_private_...
File tests/isolate/send_private_test.dart (right):

https://codereview.chromium.org/2509413002/diff/1/tests/isolate/send_private_...
tests/isolate/send_private_test.dart:6: import "dart:async";
why is dart:async needed here?

https://codereview.chromium.org/2509413002/diff/1/tests/isolate/send_private_...
tests/isolate/send_private_test.dart:33: }
You would have to skip this test in the status file for dartium

[rmacnak, 2016-11-23 23:35:53]

https://codereview.chromium.org/2509413002/diff/1/tests/isolate/send_private_...
File tests/isolate/send_private_test.dart (right):

https://codereview.chromium.org/2509413002/diff/1/tests/isolate/send_private_...
tests/isolate/send_private_test.dart:6: import "dart:async";
On 2016/11/22 06:18:21, siva wrote:
> why is dart:async needed here?

Removed

https://codereview.chromium.org/2509413002/diff/1/tests/isolate/send_private_...
tests/isolate/send_private_test.dart:33: }
On 2016/11/22 06:18:21, siva wrote:
> You would have to skip this test in the status file for dartium

Done.

[rmacnak, 2016-11-23 23:36:07]

Description was changed from

==========
An isolate created with spawn function doesn't necessarily agree with its parent
on the library private keys.

(The long-standing issue that spawn function should use snapshots would also fix
this.)

Encountered by the analyzer in https://codereview.chromium.org/2492933002/

BUG=
==========

to

==========
An isolate created with spawn function doesn't necessarily agree with its parent
on the library private keys.

(The long-standing issue that spawn function should use snapshots would also fix
this.)

Encountered by the analyzer in https://codereview.chromium.org/2492933002/

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/12de13d1ae9dec5311157b74d7be5521dcdd7d87
==========

[rmacnak, 2016-11-23 23:36:08]

Committed patchset #2 (id:20001) manually as
12de13d1ae9dec5311157b74d7be5521dcdd7d87 (presubmit successful).