Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: sdk/lib/_internal/pub/lib/src/io.dart

Issue 25094002: Adapt streams for additional stackTrace argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Upload Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/io.dart
diff --git a/sdk/lib/_internal/pub/lib/src/io.dart b/sdk/lib/_internal/pub/lib/src/io.dart
index af8168e461b073ad4ee1c712d40dc5d3e598a894..c8b3b2c45790d62fef4f870a712e7300c3d3a520 100644
--- a/sdk/lib/_internal/pub/lib/src/io.dart
+++ b/sdk/lib/_internal/pub/lib/src/io.dart
@@ -462,7 +462,8 @@ Future store(Stream stream, EventSink sink,
{bool cancelOnError: true, bool closeSink: true}) {
var completer = new Completer();
stream.listen(sink.add,
- onError: (e) {
+ onError: (e, [StackTrace stackTrace]) {
+ // TODO(floitsch): Sink.addError without stack trace.
Lasse Reichstein Nielsen 2013/10/04 08:45:17 What is the solution? Should EventSink.addError ha
floitsch 2013/10/05 18:11:48 Yes. See follow-up CLs. This is one of the reasons
sink.addError(e);
if (cancelOnError) {
completer.complete();

Powered by Google App Engine
This is Rietveld 408576698