Chromium Code Reviews| Index: pkg/sequence_zip/lib/stream_zip.dart |
| diff --git a/pkg/sequence_zip/lib/stream_zip.dart b/pkg/sequence_zip/lib/stream_zip.dart |
| index 0b4b40ad9cfb2778b39e036066ffb0f925a8b9ce..8fa3912864557230a3724d2c2b70bc314d6d005c 100644 |
| --- a/pkg/sequence_zip/lib/stream_zip.dart |
| +++ b/pkg/sequence_zip/lib/stream_zip.dart |
| @@ -20,7 +20,7 @@ class StreamZip extends Stream<List> { |
| StreamZip(Iterable<Stream> streams) : _streams = streams; |
| StreamSubscription<List> listen(void onData(List data), { |
| - void onError(Object error), |
| + Function onError, |
| void onDone(), |
| bool cancelOnError}) { |
| cancelOnError = identical(true, cancelOnError); |
| @@ -49,19 +49,19 @@ class StreamZip extends Stream<List> { |
| /// Called for each error from a subscription in [subscriptons]. |
| /// Except if [cancelOnError] is true, in which case the function below |
| /// is used instead. |
| - void handleError(Object error) { |
| - controller.addError(error); |
| + void handleError(Object error, [StackTrace stackTrace]) { |
|
Lasse Reichstein Nielsen
2013/10/04 08:45:17
Make not optional.
floitsch
2013/10/05 18:11:48
Done.
Are you sure? The closure will be given to t
Lasse Reichstein Nielsen
2013/10/07 11:55:48
Ack. Not optional yet then.
|
| + controller.addError(error, stackTrace); |
| } |
| /// Called when a subscription has an error and [cancelOnError] is true. |
| /// |
| /// Prematurely cancels all subscriptions since we know that we won't |
| /// be needing any more values. |
| - void handleErrorCancel(Object error) { |
| + void handleErrorCancel(Object error, [StackTrace stackTrace]) { |
|
Lasse Reichstein Nielsen
2013/10/04 08:45:17
Make not optional.
floitsch
2013/10/05 18:11:48
Done.
ditto.
Lasse Reichstein Nielsen
2013/10/07 11:55:48
Not here either.
|
| for (int i = 0; i < subscriptions.length; i++) { |
| subscriptions[i].cancel(); |
| } |
| - controller.addError(error); |
| + controller.addError(error, stackTrace); |
| } |
| void handleDone() { |