Chromium Code Reviews| Index: pkg/scheduled_test/lib/src/schedule.dart |
| diff --git a/pkg/scheduled_test/lib/src/schedule.dart b/pkg/scheduled_test/lib/src/schedule.dart |
| index ab2115072704178fc01ec3a1d2ae00a2e89537f5..0a5f78e3e82fa3d3e5cc4b09fd892642ed4e4c4c 100644 |
| --- a/pkg/scheduled_test/lib/src/schedule.dart |
| +++ b/pkg/scheduled_test/lib/src/schedule.dart |
| @@ -445,8 +445,8 @@ class TaskQueue { |
| return _taskFuture.whenComplete(() { |
| _taskFuture = null; |
| _schedule.heartbeat(); |
| - }).catchError((e) { |
| - var error = new ScheduleError.from(_schedule, e); |
| + }).catchError((e, [StackTrace trace]) { |
|
Lasse Reichstein Nielsen
2013/10/04 08:45:17
This is Future, not Stream?
Make not optional. We
floitsch
2013/10/05 18:11:48
Done.
|
| + var error = new ScheduleError.from(_schedule, e, stackTrace: trace); |
| _signalError(error); |
| throw _error; |
| }); |
| @@ -454,15 +454,16 @@ class TaskQueue { |
| _schedule._currentTask = null; |
| }).then((_) { |
| _onTasksCompleteCompleter.complete(); |
| - }).catchError((e) { |
| - _onTasksCompleteCompleter.completeError(e); |
| + }).catchError((e, [StackTrace stackTrace]) { |
|
Lasse Reichstein Nielsen
2013/10/04 08:45:17
Make not optional.
Assume .then is our own.
floitsch
2013/10/05 18:11:48
Done.
|
| + _onTasksCompleteCompleter.completeError(e, stackTrace); |
| throw e; |
| }).whenComplete(() { |
| if (pendingCallbacks.isEmpty) return; |
| - return _noPendingCallbacks.catchError((e) { |
| + return _noPendingCallbacks.catchError((e, [StackTrace stackTrace]) { |
|
Lasse Reichstein Nielsen
2013/10/04 08:45:17
not optional.
floitsch
2013/10/05 18:11:48
Done.
|
| // Signal the error rather than passing it through directly so that if a |
| // timeout happens after an in-task error, both are reported. |
| - _signalError(new ScheduleError.from(_schedule, e)); |
| + _signalError(new ScheduleError.from(_schedule, e, |
| + stackTrace: stackTrace)); |
| }); |
| }).whenComplete(() { |
| _schedule.heartbeat(); |