Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: sdk/lib/convert/chunked_conversion.dart

Issue 25094002: Adapt streams for additional stackTrace argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove types in closures. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream_pipe.dart ('k') | sdk/lib/io/file_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/convert/chunked_conversion.dart
diff --git a/sdk/lib/convert/chunked_conversion.dart b/sdk/lib/convert/chunked_conversion.dart
index 7674421fdf0a5bd75d14a622799795d9f372c03a..67c017bdccdbb7e8c110a38d6a8a85ea023f55b8 100644
--- a/sdk/lib/convert/chunked_conversion.dart
+++ b/sdk/lib/convert/chunked_conversion.dart
@@ -70,7 +70,7 @@ class _ConverterTransformStream<S, T> extends EventTransformStream<S, T> {
* This starts the chunked conversion.
*/
StreamSubscription<T> listen(void onData(T data),
- { void onError(error),
+ { Function onError,
void onDone(),
bool cancelOnError }) {
_eventTransformer._startChunkedConversion();
@@ -125,6 +125,7 @@ class _ConverterStreamEventTransformer<S, T>
try {
_chunkedSink.add(event);
} catch(e) {
+ // TODO(floitsch): capture stack trace.
eventSink.addError(e);
} finally {
_eventSink = null;
@@ -136,6 +137,7 @@ class _ConverterStreamEventTransformer<S, T>
try {
_chunkedSink.close();
} catch(e) {
+ // TODO(floitsch): capture stack trace.
eventSink.addError(e);
} finally {
_eventSink = null;
@@ -143,6 +145,7 @@ class _ConverterStreamEventTransformer<S, T>
}
void handleError(var errorEvent, EventSink<T> eventSink) {
+ // TODO(floitsch): capture stack trace.
eventSink.addError(errorEvent);
}
}
« no previous file with comments | « sdk/lib/async/stream_pipe.dart ('k') | sdk/lib/io/file_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698