Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: sdk/lib/async/broadcast_stream_controller.dart

Issue 25094002: Adapt streams for additional stackTrace argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove types in closures. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/utils.dart ('k') | sdk/lib/async/stream.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/broadcast_stream_controller.dart
diff --git a/sdk/lib/async/broadcast_stream_controller.dart b/sdk/lib/async/broadcast_stream_controller.dart
index aa5b111c77936bd9903cde8312cbfccf322b76ae..19f0e1ab35f60f880ab9bad601d7befca20fc406 100644
--- a/sdk/lib/async/broadcast_stream_controller.dart
+++ b/sdk/lib/async/broadcast_stream_controller.dart
@@ -30,7 +30,7 @@ class _BroadcastSubscription<T> extends _ControllerSubscription<T>
_BroadcastSubscription(_StreamControllerLifecycle controller,
void onData(T data),
- void onError(Object error),
+ Function onError,
void onDone(),
bool cancelOnError)
: super(controller, onData, onError, onDone, cancelOnError) {
@@ -173,7 +173,7 @@ abstract class _BroadcastStreamController<T>
// _StreamControllerLifecycle interface.
StreamSubscription<T> _subscribe(void onData(T data),
- void onError(Object error),
+ Function onError,
void onDone(),
bool cancelOnError) {
if (isClosed) {
@@ -227,7 +227,7 @@ abstract class _BroadcastStreamController<T>
void addError(Object error, [Object stackTrace]) {
if (!_mayAddEvent) throw _addEventError();
if (stackTrace != null) _attachStackTrace(error, stackTrace);
- _sendError(error);
+ _sendError(error, stackTrace);
}
Future close() {
@@ -256,9 +256,9 @@ abstract class _BroadcastStreamController<T>
_sendData(data);
}
- void _addError(Object error) {
+ void _addError(Object error, StackTrace stackTrace) {
assert(_isAddingStream);
- _sendError(error);
+ _sendError(error, stackTrace);
}
void _close() {
@@ -333,10 +333,10 @@ class _SyncBroadcastStreamController<T> extends _BroadcastStreamController<T> {
});
}
- void _sendError(Object error) {
+ void _sendError(Object error, StackTrace stackTrace) {
if (_isEmpty) return;
_forEachListener((_BufferingStreamSubscription<T> subscription) {
- subscription._addError(error);
+ subscription._addError(error, stackTrace);
});
}
@@ -368,12 +368,12 @@ class _AsyncBroadcastStreamController<T> extends _BroadcastStreamController<T> {
}
}
- void _sendError(Object error) {
+ void _sendError(Object error, StackTrace stackTrace) {
for (_BroadcastSubscriptionLink link = _next;
!identical(link, this);
link = link._next) {
_BroadcastSubscription<T> subscription = link;
- subscription._addPending(new _DelayedError(error));
+ subscription._addPending(new _DelayedError(error, stackTrace));
}
}
@@ -434,7 +434,7 @@ class _AsBroadcastStreamController<T>
void addError(Object error, [StackTrace stackTrace]) {
if (!isClosed && _isFiring) {
- _addPendingEvent(new _DelayedError(error));
+ _addPendingEvent(new _DelayedError(error, stackTrace));
return;
}
super.addError(error, stackTrace);
@@ -468,7 +468,7 @@ class _AsBroadcastStreamController<T>
class _DoneSubscription<T> implements StreamSubscription<T> {
int _pauseCount = 0;
void onData(void handleData(T data)) {}
- void onError(void handleErrr(Object error)) {}
+ void onError(Function handleError) {}
void onDone(void handleDone()) {}
void pause([Future resumeSignal]) {
if (resumeSignal != null) resumeSignal.then(_resume);
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/utils.dart ('k') | sdk/lib/async/stream.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698