Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: pkg/scheduled_test/lib/src/utils.dart

Issue 25094002: Adapt streams for additional stackTrace argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove types in closures. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/lib/src/utils.dart
diff --git a/pkg/scheduled_test/lib/src/utils.dart b/pkg/scheduled_test/lib/src/utils.dart
index 7323e7f183abaf114eeece7ce2a9ccfc3e0900d2..94ae958376a9dfd84fd90e9eb89d353e9e09246c 100644
--- a/pkg/scheduled_test/lib/src/utils.dart
+++ b/pkg/scheduled_test/lib/src/utils.dart
@@ -29,7 +29,7 @@ class Pair<E, F> {
/// to [completer].
void chainToCompleter(Future future, Completer completer) {
future.then((value) => completer.complete(value),
- onError: (e) => completer.completeError(e));
+ onError: completer.completeError);
}
/// Prepends each line in [text] with [prefix]. If [firstPrefix] is passed, the
@@ -85,7 +85,7 @@ Stream futureStream(Future<Stream> future) {
future.then((stream) {
stream.listen(
controller.add,
- onError: (error) => controller.addError(error),
+ onError: controller.addError,
onDone: controller.close);
}).catchError((e) {
controller.addError(e);
@@ -143,8 +143,8 @@ Pair<Stream, StreamCanceller> streamWithCanceller(Stream stream) {
var controllerStream = controller.stream;
var subscription = stream.listen((value) {
if (!controller.isClosed) controller.add(value);
- }, onError: (error) {
- if (!controller.isClosed) controller.addError(error);
+ }, onError: (error, [stackTrace]) {
+ if (!controller.isClosed) controller.addError(error, stackTrace);
}, onDone: controller.close);
return new Pair<Stream, StreamCanceller>(controllerStream, controller.close);
}
@@ -159,9 +159,9 @@ Pair<Stream, Stream> tee(Stream stream) {
stream.listen((value) {
controller1.add(value);
controller2.add(value);
- }, onError: (error) {
- controller1.addError(error);
- controller2.addError(error);
+ }, onError: (error, [stackTrace]) {
+ controller1.addError(error, stackTrace);
+ controller2.addError(error, stackTrace);
}, onDone: () {
controller1.close();
controller2.close();
« no previous file with comments | « pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart ('k') | pkg/sequence_zip/lib/stream_zip.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698