Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: pkg/sequence_zip/lib/stream_zip.dart

Issue 25094002: Adapt streams for additional stackTrace argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/sequence_zip/lib/stream_zip.dart
diff --git a/pkg/sequence_zip/lib/stream_zip.dart b/pkg/sequence_zip/lib/stream_zip.dart
index 0b4b40ad9cfb2778b39e036066ffb0f925a8b9ce..b09cfdba93d5086eb38cf6ccae8a714fcc7b90a5 100644
--- a/pkg/sequence_zip/lib/stream_zip.dart
+++ b/pkg/sequence_zip/lib/stream_zip.dart
@@ -20,7 +20,7 @@ class StreamZip extends Stream<List> {
StreamZip(Iterable<Stream> streams) : _streams = streams;
StreamSubscription<List> listen(void onData(List data), {
- void onError(Object error),
+ Function onError,
void onDone(),
bool cancelOnError}) {
cancelOnError = identical(true, cancelOnError);
@@ -46,22 +46,22 @@ class StreamZip extends Stream<List> {
}
}
- /// Called for each error from a subscription in [subscriptons].
+ /// Called for each error from a subscription in [subscriptions].
/// Except if [cancelOnError] is true, in which case the function below
/// is used instead.
- void handleError(Object error) {
- controller.addError(error);
+ void handleError(Object error, StackTrace stackTrace) {
+ controller.addError(error, stackTrace);
}
/// Called when a subscription has an error and [cancelOnError] is true.
///
/// Prematurely cancels all subscriptions since we know that we won't
/// be needing any more values.
- void handleErrorCancel(Object error) {
+ void handleErrorCancel(Object error, StackTrace stackTrace) {
for (int i = 0; i < subscriptions.length; i++) {
subscriptions[i].cancel();
}
- controller.addError(error);
+ controller.addError(error, stackTrace);
}
void handleDone() {

Powered by Google App Engine
This is Rietveld 408576698