Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: tools/gn/scope.h

Issue 2509333003: Change GN to disallow reading args defined in the same declare_args() call. (Closed)
Patch Set: update w/ review feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/scope.h
diff --git a/tools/gn/scope.h b/tools/gn/scope.h
index b87afcd6f9c756178c0ef0c4c76057d857faa868..36de0884691a6a54b9db5fbb9999a1d1e9a86357 100644
--- a/tools/gn/scope.h
+++ b/tools/gn/scope.h
@@ -112,7 +112,7 @@ class Scope {
const Settings* settings() const { return settings_; }
- // See the const_/mutable_containing_ var declaraions below. Yes, it's a
+ // See the const_/mutable_containing_ var declarations below. Yes, it's a
// bit weird that we can have a const pointer to the "mutable" one.
Scope* mutable_containing() { return mutable_containing_; }
const Scope* mutable_containing() const { return mutable_containing_; }
@@ -137,9 +137,18 @@ class Scope {
//
// counts_as_used should be set if the variable is being read in a way that
// should count for unused variable checking.
+ //
+ // found_in_scope is set to the scope that contains the definition of the
+ // ident. If the value was provided programmatically (like host_cpu),
+ // found_in_scope will be set to null.
const Value* GetValue(const base::StringPiece& ident,
bool counts_as_used);
const Value* GetValue(const base::StringPiece& ident) const;
+ const Value* GetValueWithScope(const base::StringPiece& ident,
+ const Scope** found_in_scope) const;
+ const Value* GetValueWithScope(const base::StringPiece& ident,
+ bool counts_as_used,
+ const Scope** found_in_scope);
// Returns the requested value as a mutable one if possible. If the value
// is not found in a mutable scope, then returns null. Note that the value
« tools/gn/functions.cc ('K') | « tools/gn/parse_tree.cc ('k') | tools/gn/scope.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698