Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: build/config/ui.gni

Issue 2509333003: Change GN to disallow reading args defined in the same declare_args() call. (Closed)
Patch Set: update w/ review feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/ui.gni
diff --git a/build/config/ui.gni b/build/config/ui.gni
index 20ffb958a74bd82a6d3db895f21744f21193643a..92d3d6181717c3941c751d7d26e42b139d5a7e46 100644
--- a/build/config/ui.gni
+++ b/build/config/ui.gni
@@ -33,10 +33,6 @@ declare_args() {
# of a replacement for GDI or GTK.
use_aura = is_win || is_linux
- # True means the UI is built using the "views" framework.
- toolkit_views =
- (is_mac || is_win || is_chromeos || use_aura) && !is_chromecast
-
# Whether the entire browser uses toolkit-views on Mac instead of Cocoa.
mac_views_browser = false
@@ -50,6 +46,12 @@ declare_args() {
enable_vulkan = false
}
+declare_args() {
+ # True means the UI is built using the "views" framework.
+ toolkit_views =
+ (is_mac || is_win || is_chromeos || use_aura) && !is_chromecast
+}
+
# Additional dependent variables -----------------------------------------------
#
# These variables depend on other variables and can't be set externally.
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | tools/gn/docs/reference.md » ('j') | tools/gn/functions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698