Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: build/config/ui.gni

Issue 2509333003: Change GN to disallow reading args defined in the same declare_args() call. (Closed)
Patch Set: initial patch for review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================= 5 # =============================================
6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
7 # ============================================= 7 # =============================================
8 # 8 #
9 # These flags are effectively global. Your feature flag should go near the 9 # These flags are effectively global. Your feature flag should go near the
10 # code it controls. Most of these items are here now because they control 10 # code it controls. Most of these items are here now because they control
(...skipping 15 matching lines...) Expand all
26 26
27 # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux 27 # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux
28 # that does not require X11. Enabling this feature disables use of glib, x11, 28 # that does not require X11. Enabling this feature disables use of glib, x11,
29 # Pango, and Cairo. Default to false on non-Chromecast builds. 29 # Pango, and Cairo. Default to false on non-Chromecast builds.
30 use_ozone = is_chromecast && !is_android 30 use_ozone = is_chromecast && !is_android
31 31
32 # Indicates if Aura is enabled. Aura is a low-level windowing library, sort 32 # Indicates if Aura is enabled. Aura is a low-level windowing library, sort
33 # of a replacement for GDI or GTK. 33 # of a replacement for GDI or GTK.
34 use_aura = is_win || is_linux 34 use_aura = is_win || is_linux
35 35
36 # True means the UI is built using the "views" framework.
37 toolkit_views =
38 (is_mac || is_win || is_chromeos || use_aura) && !is_chromecast
39
40 # Whether the entire browser uses toolkit-views on Mac instead of Cocoa. 36 # Whether the entire browser uses toolkit-views on Mac instead of Cocoa.
41 mac_views_browser = false 37 mac_views_browser = false
42 38
43 # Whether we should use GTKv3 instead of GTKv2. 39 # Whether we should use GTKv3 instead of GTKv2.
44 use_gtk3 = false 40 use_gtk3 = false
45 41
46 # Optional system libraries. 42 # Optional system libraries.
47 use_xkbcommon = false 43 use_xkbcommon = false
48 44
49 # Whether we should use glib, a low level C utility library. 45 # Whether we should use glib, a low level C utility library.
50 use_glib = is_linux 46 use_glib = is_linux
51 47
52 # Indicates if Wayland display server support is enabled. 48 # Indicates if Wayland display server support is enabled.
53 enable_wayland_server = is_chromeos 49 enable_wayland_server = is_chromeos
54 50
55 # Enable experimental vulkan backend. 51 # Enable experimental vulkan backend.
56 enable_vulkan = false 52 enable_vulkan = false
57 } 53 }
58 54
55 declare_args() {
56 # True means the UI is built using the "views" framework.
57 toolkit_views =
58 (is_mac || is_win || is_chromeos || use_aura) && !is_chromecast
59 }
60
59 # Additional dependent variables ----------------------------------------------- 61 # Additional dependent variables -----------------------------------------------
60 # 62 #
61 # These variables depend on other variables and can't be set externally. 63 # These variables depend on other variables and can't be set externally.
62 64
63 # Use GPU accelerated cross process image transport by default on linux builds 65 # Use GPU accelerated cross process image transport by default on linux builds
64 # with the Aura window manager. 66 # with the Aura window manager.
65 ui_compositor_image_transport = use_aura && is_linux 67 ui_compositor_image_transport = use_aura && is_linux
66 68
67 # Indicates if the UI toolkit depends on X11. 69 # Indicates if the UI toolkit depends on X11.
68 use_x11 = is_linux && !use_ozone 70 use_x11 = is_linux && !use_ozone
(...skipping 11 matching lines...) Expand all
80 use_pango = false 82 use_pango = false
81 } 83 }
82 84
83 # Whether to use atk, the Accessibility ToolKit library 85 # Whether to use atk, the Accessibility ToolKit library
84 use_atk = is_desktop_linux && use_x11 86 use_atk = is_desktop_linux && use_x11
85 # ============================================= 87 # =============================================
86 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 88 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
87 # ============================================= 89 # =============================================
88 # 90 #
89 # See comment at the top. 91 # See comment at the top.
OLDNEW
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | tools/gn/docs/reference.md » ('j') | tools/gn/functions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698