Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 250933006: Revert of NaCl: Update revision in DEPS, r13018 -> r13078. (Closed)

Created:
6 years, 8 months ago by tonyg
Modified:
6 years, 8 months ago
CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, Sam Clegg, extensions-reviews_chromium.org, JF, Derek Schuff
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, r13018 -> r13078. (https://codereview.chromium.org/249153003/) Reason for revert: Breaks official build on chromium.perf waterfall. FAILED: cd ../../native_client/src/shared/gio; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=gio_lib; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/../../native_client/src/shared/gio; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../../../native_client/build/build_nexe.py -t ../../../../out/Release/gen/sdk/ --arch x86-32 --build glibc_nso --root ../../../.. --name ../../../../out/Release/gen/tc_glibc/lib32/libgio.so --objdir ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib "--include-dirs=../../../../out/Release/gen/tc_glibc/include ../../../.. ../../../src/third_party ../../../.." "--compile_flags=-m32 -fPIC -fomit-frame-pointer -fasynchronous-unwind-tables -O2 -g -Wall -fdiagnostics-show-option -Werror " --gomadir "" "--defines=__linux__ \"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS BLINK_SCALE_FILTERS_AT_RECORD_TIME \"NACL_LINUX=0\" \"NACL_ANDROID=0\" \"NACL_OSX=1\" \"NACL_WINDOWS=0\" GOOGLE_CHROME_BUILD ENABLE_RLZ \"USE_LIBJPEG_TURBO=1\" ENABLE_ONE_CLICK_SIGNIN \"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" DISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE \"ENABLE_EGLIMAGE=1\" \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGIN_INSTALLATION=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\" \"ENABLE_FULL_PRINTING=1\" \"ENABLE_PRINTING=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_MANAGED_USERS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" \"NACL_TARGET_SUBARCH=32\" \"NACL_TARGET_ARCH=x86\" \"NACL_BUILD_SUBARCH=32\" \"NACL_BUILD_ARCH=x86\"" "--link_flags=-m32 -B../../../../out/Release/gen/tc_glibc/lib32 " "--source-list=../../../../out/gypfiles/native_client/src/shared/gio/glibc-x86-32-so.gio_lib.source_list.gypcmd" /Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld: cannot find crti.o: No such file or directory /Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld: cannot find crtbeginS.o: No such file or directory collect2: ld returned 1 exit status ../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++ -o ../../../../out/Release/gen/tc_glibc/lib32/libgio.so -Wl,--as-needed ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gprintf.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem_snapshot.o -m32 -B../../../../out/Release/gen/tc_glibc/lib32 -shared -Wl,-soname,libgio.so FAILED: Command '['../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++', '-o', '../../../../out/Release/gen/tc_glibc/lib32/libgio.so', '-Wl,--as-needed', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gprintf.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem_snapshot.o', '-m32', '-B../../../../out/Release/gen/tc_glibc/lib32', '-shared', '-Wl,-soname,libgio.so']' returned non-zero exit status 1 FAILED: cd ../../native_client/src/shared/gio; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=gio_lib; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/../../native_client/src/shared/gio; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../../../native_client/build/build_nexe.py -t ../../../../out/Release/gen/sdk/ --arch x86-64 --build glibc_nso --root ../../../.. --name ../../../../out/Release/gen/tc_glibc/lib64/libgio.so --objdir ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib "--include-dirs=../../../../out/Release/gen/tc_glibc/include ../../../.. ../../../src/third_party ../../../.." "--compile_flags=-m64 -fPIC -fomit-frame-pointer -fasynchronous-unwind-tables -O2 -g -Wall -fdiagnostics-show-option -Werror " --gomadir "" "--defines=__linux__ \"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS BLINK_SCALE_FILTERS_AT_RECORD_TIME \"NACL_LINUX=0\" \"NACL_ANDROID=0\" \"NACL_OSX=1\" \"NACL_WINDOWS=0\" GOOGLE_CHROME_BUILD ENABLE_RLZ \"USE_LIBJPEG_TURBO=1\" ENABLE_ONE_CLICK_SIGNIN \"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" DISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE \"ENABLE_EGLIMAGE=1\" \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGIN_INSTALLATION=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\" \"ENABLE_FULL_PRINTING=1\" \"ENABLE_PRINTING=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_MANAGED_USERS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" \"NACL_TARGET_SUBARCH=32\" \"NACL_TARGET_ARCH=x86\" \"NACL_BUILD_SUBARCH=32\" \"NACL_BUILD_ARCH=x86\"" "--link_flags=-B../../../../out/Release/gen/tc_glibc/lib64 " "--source-list=../../../../out/gypfiles/native_client/src/shared/gio/glibc-x86-64-so.gio_lib.source_list.gypcmd" /Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld: cannot find crti.o: No such file or directory /Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld: cannot find crtbeginS.o: No such file or directory collect2: ld returned 1 exit status ../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++ -o ../../../../out/Release/gen/tc_glibc/lib64/libgio.so -Wl,--as-needed ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gprintf.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem_snapshot.o -B../../../../out/Release/gen/tc_glibc/lib64 -shared -Wl,-soname,libgio.so FAILED: Command '['../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++', '-o', '../../../../out/Release/gen/tc_glibc/lib64/libgio.so', '-Wl,--as-needed', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gprintf.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem_snapshot.o', '-B../../../../out/Release/gen/tc_glibc/lib64', '-shared', '-Wl,-soname,libgio.so']' returned non-zero exit status 1 ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/60425/steps/compile/logs/stdio Original issue's description: > NaCl: Update revision in DEPS, r13018 -> r13078. > > Chromium NaCl scripts now uses package_version to extract. > > Now that we have split up the toolchain into multiple tars, we should > use the package versioning script to manage which tars to extract. > Unfortunately, currently the SDK uses different directory names compared > to what the NaCl toolchain directories normally use, so we also must map > and move the toolchain directories to the SDK ones. > > BUG=365817 > TEST= trybots > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266284 TBR=mseaborn@chromium.org,jvoung@chromium.org,bradnelson@chromium.org,noelallen@chromium.org,dyen@chromium.org NOTREECHECKS=true NOTRY=true BUG=365817 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -86 lines) Patch
M DEPS View 2 chunks +3 lines, -2 lines 0 comments Download
M build/download_nacl_toolchains.py View 2 chunks +16 lines, -12 lines 0 comments Download
M chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py View 1 chunk +3 lines, -6 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 5 chunks +87 lines, -56 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Created Revert of NaCl: Update revision in DEPS, r13018 -> r13078.
6 years, 8 months ago (2014-04-26 01:53:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/250933006/1
6 years, 8 months ago (2014-04-26 02:04:20 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 02:30:21 UTC) #3
Message was sent while issue was closed.
Change committed as 266326

Powered by Google App Engine
This is Rietveld 408576698