Make createEvent do case-insensitive matches

Make createEvent do case-insensitive matches for certain interface values as specified here:
http://dom.spec.whatwg.org/#dom-document-createevent

Update the python generator scripts for this and add tests to create-event.html.

This behavior matches Firefox and IE11.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173331

[rwlbuis, 2014-04-26 23:30:56]

PTAL

[arv (Not doing code reviews), 2014-04-28 13:49:29]

Do we really want to do this? Is there a site that depends on this? I would
prefer if we could tighten the spec here instead.

[arv (Not doing code reviews), 2014-04-28 14:20:21]

I filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=25491


On Mon, Apr 28, 2014 at 9:49 AM, <arv@chromium.org> wrote:

> Do we really want to do this? Is there a site that depends on this? I would
> prefer if we could tighten the spec here instead.
>
> https://codereview.chromium.org/250933005/
>



-- 
erik

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rwlbuis, 2014-04-28 14:48:25]

On 2014/04/28 13:49:29, arv wrote:
> Do we really want to do this? Is there a site that depends on this? I would
> prefer if we could tighten the spec here instead.

I saw some internal w3c tests test this but do not know of sites using it.
Thanks for filing the w3c bug, hopefully we'll get some answers.

[rwlbuis, 2014-05-05 15:45:13]

On 2014/04/28 14:20:21, arv wrote:
> I filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=25491

I noticed it was closed as wontfix, so the spec remains as it is it seems.
Should we follow that or keep things as-is for now?

[arv (Not doing code reviews), 2014-05-05 15:52:24]

On 2014/05/05 15:45:13, rwlbuis wrote:
> On 2014/04/28 14:20:21, arv wrote:
> > I filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=25491
> 
> I noticed it was closed as wontfix, so the spec remains as it is it seems.
> Should we follow that or keep things as-is for now?

lets follow the spec. Reviewing again.

[arv (Not doing code reviews), 2014-05-05 16:06:11]

LGTM

https://codereview.chromium.org/250933005/diff/20001/Source/build/scripts/mak...
File Source/build/scripts/make_event_factory.py (right):

https://codereview.chromium.org/250933005/diff/20001/Source/build/scripts/mak...
Source/build/scripts/make_event_factory.py:42: or name.startswith('Event')
Why do we get "Events" here?

https://codereview.chromium.org/250933005/diff/20001/Source/build/scripts/mak...
Source/build/scripts/make_event_factory.py:42: or name.startswith('Event')
maybe?

or name == 'Event'
or name == 'Events'
...

instead?

I find it a bit misleading to use startsWith since EventFoo is not valid.

[rwlbuis, 2014-05-05 16:06:56]

On 2014/05/05 16:06:11, arv wrote:
> LGTM
> 
>
https://codereview.chromium.org/250933005/diff/20001/Source/build/scripts/mak...
> File Source/build/scripts/make_event_factory.py (right):
> 
>
https://codereview.chromium.org/250933005/diff/20001/Source/build/scripts/mak...
> Source/build/scripts/make_event_factory.py:42: or name.startswith('Event')
> Why do we get "Events" here?
> 
>
https://codereview.chromium.org/250933005/diff/20001/Source/build/scripts/mak...
> Source/build/scripts/make_event_factory.py:42: or name.startswith('Event')
> maybe?
> 
> or name == 'Event'
> or name == 'Events'
> ...
> 
> instead?
> 
> I find it a bit misleading to use startsWith since EventFoo is not valid.

Good points, will fix.

[rwlbuis, 2014-05-05 17:19:07]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-05-05 17:19:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/250933005/40001

[rwlbuis, 2014-05-05 19:08:30]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-05-05 19:08:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/250933005/40001

[commit-bot: I haz the power, 2014-05-05 19:09:28]

Change committed as 173331