Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2509323004: Revert of Implement Android key/value backup (Closed)

Created:
4 years, 1 month ago by amineer_google
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of Implement Android key/value backup (patchset #1 id:1 of https://codereview.chromium.org/2511713002/ ) Reason for revert: Breaks build. Please don't reland. https://uberchromegw.corp.google.com/i/official.android.continuous/builders/beta-arm/builds/5096 Original issue's description: > Implement Android key/value backup > > This replaces our previous impmentation of (Dolly) Auto Backup. > Only the preferences needed to restore the user's signin atate > and sync state are backed up. > > BUG=661188 > > Review-Url: https://codereview.chromium.org/2496693002 > Cr-Commit-Position: refs/heads/master@{#432517} > (cherry picked from commit d56b7ec3e6e6c3236835414584f4205283beb218) > > Committed: https://chromium.googlesource.com/chromium/src/+/9dd9283bac8aa9908d6868a052e088a9839499b4 TBR=aberent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+577 lines, -1035 lines) Patch
M chrome/android/java/AndroidManifest.xml View 2 chunks +6 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java View 1 chunk +231 lines, -240 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java View 1 chunk +0 lines, -65 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +1 line, -1 line 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java View 1 chunk +209 lines, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java View 1 chunk +130 lines, -328 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/android/chrome_backup_agent.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/android/chrome_backup_agent.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/android/chrome_backup_agent_unittest.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D chrome/browser/android/chrome_backup_watcher.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/android/chrome_backup_watcher.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
amineer_google
Created Revert of Implement Android key/value backup
4 years, 1 month ago (2016-11-18 03:31:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509323004/1
4 years, 1 month ago (2016-11-18 03:33:22 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-18 03:33:24 UTC) #5
amineer_google
On 2016/11/18 03:33:24, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 1 month ago (2016-11-18 03:34:52 UTC) #6
amineer_google
On 2016/11/18 03:34:52, amineer_google wrote: > On 2016/11/18 03:33:24, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-11-18 03:35:06 UTC) #7
sgurun-gerrit only
On 2016/11/18 03:35:06, amineer_google wrote: > On 2016/11/18 03:34:52, amineer_google wrote: > > On 2016/11/18 ...
4 years, 1 month ago (2016-11-18 03:39:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509323004/1
4 years, 1 month ago (2016-11-18 03:41:26 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:02:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698