Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2509293003: Add SHA-256 of RSA key for Chrome OS Flash CRX files. (Closed)

Created:
4 years, 1 month ago by Greg K
Modified:
3 years, 10 months ago
Reviewers:
Sorin Jianu
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SHA-256 of RSA key for Chrome OS Flash CRX files. This adds the SHA-256 of the RSA key that we use to sign CRX packages on Chrome. BUG=630420 Committed: https://crrev.com/ff1915fa8831557f28d074bb3432a03c6443eb04 Cr-Commit-Position: refs/heads/master@{#434823}

Patch Set 1 #

Patch Set 2 : Add SHA-256 of RSA key for Chrome OS Flash CRX files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Greg K
Sorin, PTAL. Thanks, Greg
4 years, 1 month ago (2016-11-22 16:20:24 UTC) #8
Sorin Jianu
lgtm Thank you! Coding style lgtm, don't know if this is functionally correct.
4 years, 1 month ago (2016-11-22 16:24:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509293003/20001
4 years ago (2016-11-28 23:30:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 01:49:52 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 01:53:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff1915fa8831557f28d074bb3432a03c6443eb04
Cr-Commit-Position: refs/heads/master@{#434823}

Powered by Google App Engine
This is Rietveld 408576698