Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2509293002: [Test] Remove now unecessary interpreter()->Initialize() from tests. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Test] Remove now unecessary interpreter()->Initialize() from tests. Committed: https://crrev.com/7f8681c08cb29c506d4025707666c36e6f50be05 Cr-Commit-Position: refs/heads/master@{#41086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/interpreter/interpreter-tester.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/test-source-positions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
rmcilroy
Mythri, PTAL, thanks.
4 years, 1 month ago (2016-11-17 14:28:52 UTC) #4
mythria
lgtm.
4 years, 1 month ago (2016-11-17 16:37:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509293002/1
4 years, 1 month ago (2016-11-17 16:37:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 16:40:17 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f8681c08cb29c506d4025707666c36e6f50be05
Cr-Commit-Position: refs/heads/master@{#41086}

Powered by Google App Engine
This is Rietveld 408576698