Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2509273005: [Mac] Remove NSScreen renderer sandbox warmup. (Closed)

Created:
4 years, 1 month ago by Robert Sesek
Modified:
4 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Remove NSScreen renderer sandbox warmup. This should no longer be necessary now that the scrollbar animations are no longer driven by NSAnimation (https://codereview.chromium.org/529103002/). BUG=306348, 533537 R=avi@chromium.org Committed: https://crrev.com/9cf04c9e74a140d91cea9602298cace5b6277a6f Cr-Commit-Position: refs/heads/master@{#434775}

Patch Set 1 #

Patch Set 2 : SetApplicationIsDaemon #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/common/sandbox_mac.mm View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_mac.mm View 1 chunk +0 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/css1/box_properties/acid_test-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/css2.1/t09-c5526c-display-00-e-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/css3/selectors3/html/css3-modsel-25-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/css3/selectors3/html/css3-modsel-70-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/css3/selectors3/xhtml/css3-modsel-25-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/css3/selectors3/xhtml/css3-modsel-70-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/css3/selectors3/xml/css3-modsel-25-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/css3/selectors3/xml/css3-modsel-70-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/block/basic/011-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/block/margin-collapse/103-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/css/non-standard-checkbox-size-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/001-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/basic-inputs-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/checkbox/checkbox-appearance-basic-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/file/file-input-disabled-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/form-element-geometry-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/formmove-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/formmove2-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/indeterminate-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/input-appearance-height-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/input-value-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/radio/radio-appearance-basic-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/inline/positionedLifetime-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/parser/bad-xml-slash-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/replaced/replaced-breaking-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/textIteratorNilRenderer-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/whitespace/normal-after-nowrap-breaking-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/forms/checkbox-focus-by-mouse-then-keydown-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/forms/radio-focus-by-mouse-then-keydown-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug1318-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug4527-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla_expected_failures/core/captions1-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla_expected_failures/core/captions2-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/virtual/parsehtmlonmainthread_coalesce/fast/parser/bad-xml-slash-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/virtual/parsehtmlonmainthread_sync/fast/parser/bad-xml-slash-expected.png View 1 2 Binary file 0 comments Download

Messages

Total messages: 8 (3 generated)
Robert Sesek
You can see a comparison of the layout test results here: https://storage.googleapis.com/chromium-layout-test-archives/mac10_11_retina_blink_rel/1299/layout-test-results/results.html The baselines for ...
4 years ago (2016-11-28 16:29:17 UTC) #1
Avi (use Gerrit)
lgtm
4 years ago (2016-11-28 18:07:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509273005/40001
4 years ago (2016-11-28 21:50:45 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-28 23:36:34 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-28 23:37:56 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9cf04c9e74a140d91cea9602298cace5b6277a6f
Cr-Commit-Position: refs/heads/master@{#434775}

Powered by Google App Engine
This is Rietveld 408576698