Split off 'Google' category into separate ADMX/ADML files

components/policy/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/features.gni")
 import("//build/toolchain/toolchain.gni")
 import("//components/policy/resources/policy_templates.gni")
 import("//third_party/protobuf/proto_library.gni")
 import("//tools/grit/grit_rule.gni")
@@ skipping 93 matching lines @@
           rebase_path(app_restrictions_path, root_build_dir),
       "--risk-tag-header=" + rebase_path(risk_tag_header_path, root_build_dir),
       chrome_version_path,
       target_os,
       chromeos_flag,
       rebase_path("resources/policy_templates.json", root_build_dir),
     ]
   }
 
   policy_templates_grd_file = "resources/policy_templates.grd"
+
+  if (is_chrome_branded) {
+    # Creates google.admx and google.adml files that define a common 'Google'
+    # category used for Chrome, Chrome OS and possibly external tools, see
+    # crbug.com/665400.
+    action("create_google_admx") {
+      script = "tools/create_google_admx.py"
+      outputs = policy_templates_windows_google_outputs
+
+      # Don't pass in outputs directly, it would exceed a limit on Windows!
+      args = [
+               "--basedir",
+               rebase_path(policy_templates_base_dir, root_build_dir),

[Nico, 2016/11/18 17:27:16]

Are the files in this directory used as input? If so, if you don't list them in
inputs, the action won't re-run if the inputs change. (Look at gn's depfile
thingy for how to make the tool write a depfile if you can't pass all the inputs
on the command line)

[ljusten (tachyonic), 2016/11/19 17:12:35]

It defines the output path. Thanks for the tip with the depfile, that's good to
know!

+               "--grd_strip_path_prefix",
+               "app/policy/",
+               "--grd_input",
+               rebase_path(policy_templates_grd_file, root_build_dir),

[Nico, 2016/11/18 17:27:16]

this should probably be listed as an input then?

[ljusten (tachyonic), 2016/11/19 17:12:35]

Yes, you're right! Thanks.

+               "--grit_info",
+               rebase_path(grit_info_script, root_build_dir),
+               "-D",
+               "gen_policy_templates_win",
+             ] + grit_defines
+    }
+  }
+
   grit("policy_templates") {
     source = policy_templates_grd_file
     use_qualified_include = true
     output_dir = "$root_gen_dir/chrome"
     outputs = []
     defines = []
 
     if (gen_policy_templates_common) {
       outputs += policy_templates_doc_outputs
       defines += [ "gen_policy_templates_common" ]
@@ skipping 10 matching lines @@
       outputs += policy_templates_mac_outputs
       defines += [
         "mac_bundle_id=$chrome_mac_bundle_id",
         "gen_policy_templates_mac",
       ]
     }
     if (gen_policy_templates_win) {
       outputs += policy_templates_windows_outputs
       defines += [ "gen_policy_templates_win" ]
     }
+    if (is_chrome_branded) {
+      deps = [
+        ":create_google_admx",
+      ]
+    }
   }
 
   # Run the proto compiler over the generated file and make it a component.
   component("cloud_policy_proto_generated_compile") {
     public_deps = [
       ":cloud_policy_proto_generated_compile_proto",
     ]
   }
   proto_library("cloud_policy_proto_generated_compile_proto") {
     visibility = [ ":cloud_policy_proto_generated_compile" ]
@@ skipping 184 matching lines @@
                rebase_path(grit_info_script, root_build_dir),
                "-D",
                "gen_policy_templates_common",
                "-D",
                "gen_policy_templates_win",
              ] + grit_defines
       deps = [
         ":add_version",
         ":policy_templates",
       ]
+      if (is_chrome_branded) {
+        inputs += policy_templates_windows_google_outputs
+        deps += [ ":create_google_admx" ]
+        args += [ "--include_google_admx" ]
+      }
     }
   }
 }