Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2509243002: Revert of Don't reset scroll position of contents on every ScrollView layout. (Closed)

Created:
4 years, 1 month ago by msramek
Modified:
4 years, 1 month ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't reset scroll position of contents on every ScrollView layout. (patchset #3 id:40001 of https://codereview.chromium.org/2509783002/ ) Reason for revert: This change likely breaks NativeWidgetMacTest.WindowModalSheet test on Mac. https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/33145/steps/views_unittests%20on%20Mac-10.9/logs/NativeWidgetMacTest.WindowModalSheet Original issue's description: > Don't reset scroll position of contents on every ScrollView layout. > > Also do a little cleanup in ash scrollview related code. > > BUG=664930 > > Committed: https://crrev.com/210e0fa83113f83d29ac3c1203c2047e905601e9 > Cr-Commit-Position: refs/heads/master@{#432749} TBR=sky@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664930 Committed: https://crrev.com/cd3b2a6045f96ac2670e84b92c89acf5a3a99d75 Cr-Commit-Position: refs/heads/master@{#432827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -44 lines) Patch
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/fixed_sized_scroll_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M ui/views/controls/scroll_view_unittest.cc View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
msramek
Created Revert of Don't reset scroll position of contents on every ScrollView layout.
4 years, 1 month ago (2016-11-17 09:19:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509243002/1
4 years, 1 month ago (2016-11-17 09:19:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 09:21:01 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cd3b2a6045f96ac2670e84b92c89acf5a3a99d75 Cr-Commit-Position: refs/heads/master@{#432827}
4 years, 1 month ago (2016-11-17 09:25:47 UTC) #7
Evan Stade
4 years, 1 month ago (2016-11-17 22:45:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2507053004/ by estade@chromium.org.

The reason for reverting is: tapted@ disabled the failing test, which we suspect
was only failing due to how this patch affected sharding.

Powered by Google App Engine
This is Rietveld 408576698