Touch emulator: overwrite timestamps from mouse event with current time.

Touch emulator: overwrite timestamps from mouse event with current time.

On some platfroms, mouse events come with a bad timestamp, which leads to
awkward time-dependent gestures. For example, fling animation may be almost
instant.
Using base::TimeTicks::Now() is good enough for emulation purposes, because
emulator spawns new events itself.

BUG=367156
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266548

[dgozman, 2014-04-25 16:52:18]

Take a look please.
This works on linux, and I will test canary on Mac and Windows once it lands.

[jdduke (slow), 2014-04-25 16:56:05]

lgtm with nit, thanks.

https://codereview.chromium.org/250923005/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/touch_emulator.cc (right):

https://codereview.chromium.org/250923005/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_emulator.cc:319: void
TouchEmulator::FillPinchEvent(const WebInputEvent& event) {
Could you make this |const WebGestureEvent& event) ? Just want it to be clear
we're getting timestamps from "valid" sources at all times.

[dgozman, 2014-04-28 09:34:21]

https://codereview.chromium.org/250923005/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/touch_emulator.cc (right):

https://codereview.chromium.org/250923005/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_emulator.cc:319: void
TouchEmulator::FillPinchEvent(const WebInputEvent& event) {
On 2014/04/25 16:56:05, jdduke wrote:
> Could you make this |const WebGestureEvent& event) ? Just want it to be clear
> we're getting timestamps from "valid" sources at all times.

Done.

[dgozman, 2014-04-28 09:34:26]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-04-28 09:35:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/250923005/20001

[commit-bot: I haz the power, 2014-04-28 09:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 09:43:19]

Try jobs failed on following builders:
  tryserver.chromium on ios_dbg_simulator

[dgozman, 2014-04-28 11:03:51]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-04-28 11:04:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/250923005/20001

[commit-bot: I haz the power, 2014-04-28 13:52:01]

Change committed as 266548

[Nico, 2014-04-28 18:26:36]

A revert of this CL has been created in
https://codereview.chromium.org/252963002/ by thakis@chromium.org.

The reason for reverting is: Somewhat speculative; looks like this caused
TouchEmulatorTest failures on valgrind:

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28t...

TouchEmulatorTest.Pinch:
../../content/browser/renderer_host/input/touch_emulator_unittest.cc:254:
Failure
Value of: ExpectedEvents()
Actual: "TouchEnd GestureFlingStart"
Expected: "TouchEnd GestureScrollEnd"

etc.