content/browser/renderer_host/input/touch_action_filter_unittest.cc - Issue 250923004: Synthesize ctrl-wheel events on touchpad pinch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_action_filter_unittest.cc

Issue 250923004: Synthesize ctrl-wheel events on touchpad pinch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix windows build and tweaks Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/mock_input_ack_handler.h ('K') | « content/browser/renderer_host/input/mock_input_ack_handler.cc ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | content/common/input/synthetic_web_input_event_builders.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_action_filter_unittest.cc

diff --git a/content/browser/renderer_host/input/touch_action_filter_unittest.cc b/content/browser/renderer_host/input/touch_action_filter_unittest.cc

index 38221245f6b0bbed9a4c952d66d5766242be0147..71a3c1ea43acba8e03a4479746b7d778d2c27795 100644

--- a/content/browser/renderer_host/input/touch_action_filter_unittest.cc

+++ b/content/browser/renderer_host/input/touch_action_filter_unittest.cc

@@ -382,7 +382,8 @@ TEST(TouchActionFilterTest, Pinch) {

WebGestureEvent pinch_begin = SyntheticWebGestureEventBuilder::Build(

WebInputEvent::GesturePinchBegin, WebGestureEvent::Touchscreen);

WebGestureEvent pinch_update =

- SyntheticWebGestureEventBuilder::BuildPinchUpdate(1.2f, 5, 5, 0);

+ SyntheticWebGestureEventBuilder::BuildPinchUpdate(

+ 1.2f, 5, 5, 0, WebGestureEvent::Touchscreen);

WebGestureEvent pinch_end = SyntheticWebGestureEventBuilder::Build(

WebInputEvent::GesturePinchEnd, WebGestureEvent::Touchscreen);

WebGestureEvent scroll_end = SyntheticWebGestureEventBuilder::Build(