Remove always-false settings for text track selection

Remove always-false settings for text track selection

Since these settings were not exposed to Chromium or set in any other
way, they were always false. shouldDisplayTextDescriptions was not even
used internally.

While the text track selection needs to be improved, but these settings
made it look like it was more sophisticated than it really is. A new
setting for hard-of-hearing users (preferring captions over subtitles)
may eventually be needed, but that would be a single setting only.

The removed comment no longer makes sense, because the maximum value
returned by textTrackSelectionScore is now the return value of
textTrackLanguageSelectionScore, which is not greater than itself...

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172695

[philipj_slow, 2014-04-25 14:44:04]

PTAL. If you have a *.in rubberstamp close by that would be nice, otherwise I'll
find one later.

[acolwell GONE FROM CHROMIUM, 2014-04-25 23:57:27]

lgtm % nit

https://codereview.chromium.org/250923003/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/250923003/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:2403: return (languages.size() -
languageMatchIndex) * 10;
nit: Do we need the '* 10' here? If so, please add a comment saying why.

[philipj_slow, 2014-04-26 00:02:06]

https://codereview.chromium.org/250923003/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/250923003/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:2403: return (languages.size() -
languageMatchIndex) * 10;
On 2014/04/25 23:57:27, acolwell wrote:
> nit: Do we need the '* 10' here? If so, please add a comment saying why.

Not any more, thanks!

[philipj_slow, 2014-04-26 00:03:41]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-04-26 00:04:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/250923003/20001

[commit-bot: I haz the power, 2014-04-26 03:29:23]

Change committed as 172695