Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: ui/file_manager/gallery/js/slide_mode.js

Issue 2509223002: Gallery: Correct tab order of modal tool bar in edit mode. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * Slide mode displays a single image and has a set of controls to navigate 6 * Slide mode displays a single image and has a set of controls to navigate
7 * between the images and to edit an image. 7 * between the images and to edit an image.
8 * 8 *
9 * @param {!HTMLElement} container Main container element. 9 * @param {!HTMLElement} container Main container element.
10 * @param {!HTMLElement} content Content container element. 10 * @param {!HTMLElement} content Content container element.
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 * @private 402 * @private
403 * @const 403 * @const
404 */ 404 */
405 this.editBarMain_ = util.createChild(this.editBarSpacer_, 'edit-main'); 405 this.editBarMain_ = util.createChild(this.editBarSpacer_, 'edit-main');
406 406
407 /** 407 /**
408 * @type {!HTMLElement} 408 * @type {!HTMLElement}
409 * @private 409 * @private
410 * @const 410 * @const
411 */ 411 */
412 this.editBarMode_ = util.createChild(this.container_, 'edit-modal'); 412 this.editBarMode_ = document.createElement('div');
413 this.editBarMode_.className = 'edit-modal';
414 // Edito modal should be inserted before the bottom toolbar to make the tab
oka 2016/11/17 07:26:40 typo: Edito
fukino 2016/11/17 08:38:00 Done.
415 // order and visual position consistent.
416 this.container_.insertBefore(
417 this.editBarMode_, document.querySelector('#bottom-toolbar'));
413 418
414 /** 419 /**
415 * @type {!HTMLElement} 420 * @type {!HTMLElement}
416 * @private 421 * @private
417 * @const 422 * @const
418 */ 423 */
419 this.editBarModeWrapper_ = util.createChild( 424 this.editBarModeWrapper_ = util.createChild(
420 this.editBarMode_, 'edit-modal-wrapper dimmable'); 425 this.editBarMode_, 'edit-modal-wrapper dimmable');
421 this.editBarModeWrapper_.hidden = true; 426 this.editBarModeWrapper_.hidden = true;
422 427
(...skipping 1715 matching lines...) Expand 10 before | Expand all | Expand 10 after
2138 /** 2143 /**
2139 * Handles mouse up events. 2144 * Handles mouse up events.
2140 * @param {!Event} event Wheel event. 2145 * @param {!Event} event Wheel event.
2141 * @private 2146 * @private
2142 */ 2147 */
2143 TouchHandler.prototype.onMouseUp_ = function(event) { 2148 TouchHandler.prototype.onMouseUp_ = function(event) {
2144 if (event.button !== 0) 2149 if (event.button !== 0)
2145 return; 2150 return;
2146 this.clickStarted_ = false; 2151 this.clickStarted_ = false;
2147 }; 2152 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698