Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2509223002:
Gallery: Correct tab order of modal tool bar in edit mode. (Closed)
|
Created:
4 years, 1 month ago by fukino Modified:
4 years, 1 month ago Reviewers:
oka CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionGallery: Correct tab order of modal tool bar in edit mode.
The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's DOM,
but it is visually shown above the #bottom-toolbar.
It made the tab order inconsistent with the visual position of toolbars.
This CL fixes the tab order by inserting the modal bar at the right position.
BUG=652352
TEST=In edit mode with brightness options, I comfirmed that the first element of the bottom bar ("Overrite original") was focused after I tab through the controls of brightness options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/c49ae19a47f0a780ed33b2341cfe56acc77efe50
Cr-Commit-Position: refs/heads/master@{#432822}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Correct a comment. #Patch Set 3 : Fix a closure error. #Messages
Total messages: 18 (11 generated)
Description was changed from ========== Gallery: Correct tab order of modal tool bar in edit mode. The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's DOM, but it is visually shown above the #bottom-toolbar. It made the tab order inconsistent with the visual position of toolbars. This CL fixes the tab order by inserting the modal bar at the right position. BUG=652352 TEST=manually tested. ========== to ========== Gallery: Correct tab order of modal tool bar in edit mode. The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's DOM, but it is visually shown above the #bottom-toolbar. It made the tab order inconsistent with the visual position of toolbars. This CL fixes the tab order by inserting the modal bar at the right position. BUG=652352 TEST=manually tested. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
fukino@chromium.org changed reviewers: + oka@chromium.org
PTAL.
Could you elaborate exactly what test you performed?
lgtm https://codereview.chromium.org/2509223002/diff/1/ui/file_manager/gallery/js/... File ui/file_manager/gallery/js/slide_mode.js (right): https://codereview.chromium.org/2509223002/diff/1/ui/file_manager/gallery/js/... ui/file_manager/gallery/js/slide_mode.js:414: // Edito modal should be inserted before the bottom toolbar to make the tab typo: Edito
Description was changed from
==========
Gallery: Correct tab order of modal tool bar in edit mode.
The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's
DOM,
but it is visually shown above the #bottom-toolbar.
It made the tab order inconsistent with the visual position of toolbars.
This CL fixes the tab order by inserting the modal bar at the right position.
BUG=652352
TEST=manually tested.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Gallery: Correct tab order of modal tool bar in edit mode.
The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's
DOM,
but it is visually shown above the #bottom-toolbar.
It made the tab order inconsistent with the visual position of toolbars.
This CL fixes the tab order by inserting the modal bar at the right position.
BUG=652352
TEST=In edit mode with brightness options, I comfirmed that the first element of
the bottom bar ("Overrite original") was focused after I tab through the
controls of brightness options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
The CQ bit was checked by fukino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
Thanks! I updated the TEST= line and fixed a closure error. https://codereview.chromium.org/2509223002/diff/1/ui/file_manager/gallery/js/... File ui/file_manager/gallery/js/slide_mode.js (right): https://codereview.chromium.org/2509223002/diff/1/ui/file_manager/gallery/js/... ui/file_manager/gallery/js/slide_mode.js:414: // Edito modal should be inserted before the bottom toolbar to make the tab On 2016/11/17 07:26:40, oka wrote: > typo: Edito Done.
The CQ bit was checked by fukino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org Link to the patchset: https://codereview.chromium.org/2509223002/#ps40001 (title: "Fix a closure error.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Gallery: Correct tab order of modal tool bar in edit mode.
The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's
DOM,
but it is visually shown above the #bottom-toolbar.
It made the tab order inconsistent with the visual position of toolbars.
This CL fixes the tab order by inserting the modal bar at the right position.
BUG=652352
TEST=In edit mode with brightness options, I comfirmed that the first element of
the bottom bar ("Overrite original") was focused after I tab through the
controls of brightness options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Gallery: Correct tab order of modal tool bar in edit mode.
The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's
DOM,
but it is visually shown above the #bottom-toolbar.
It made the tab order inconsistent with the visual position of toolbars.
This CL fixes the tab order by inserting the modal bar at the right position.
BUG=652352
TEST=In edit mode with brightness options, I comfirmed that the first element of
the bottom bar ("Overrite original") was focused after I tab through the
controls of brightness options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from
==========
Gallery: Correct tab order of modal tool bar in edit mode.
The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's
DOM,
but it is visually shown above the #bottom-toolbar.
It made the tab order inconsistent with the visual position of toolbars.
This CL fixes the tab order by inserting the modal bar at the right position.
BUG=652352
TEST=In edit mode with brightness options, I comfirmed that the first element of
the bottom bar ("Overrite original") was focused after I tab through the
controls of brightness options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Gallery: Correct tab order of modal tool bar in edit mode.
The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's
DOM,
but it is visually shown above the #bottom-toolbar.
It made the tab order inconsistent with the visual position of toolbars.
This CL fixes the tab order by inserting the modal bar at the right position.
BUG=652352
TEST=In edit mode with brightness options, I comfirmed that the first element of
the bottom bar ("Overrite original") was focused after I tab through the
controls of brightness options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/c49ae19a47f0a780ed33b2341cfe56acc77efe50
Cr-Commit-Position: refs/heads/master@{#432822}
==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c49ae19a47f0a780ed33b2341cfe56acc77efe50 Cr-Commit-Position: refs/heads/master@{#432822} |
