third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp - Issue 2509213003: DO NOT SUBMIT: enable v8bsc and instrument partitionlloc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

Issue 2509213003: DO NOT SUBMIT: enable v8bsc and instrument partitionlloc

Patch Set: misc -- most importantly, passing the actualSize to realloc Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

index 87116cda10a25f213fbe150663baee1defe7f8ad..a28bc4c1d646e05f7de2a0c1bf402506d622a4c2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

@@ -145,6 +145,7 @@ String SerializedScriptValue::toWireString() const {

size_t stringSizeBytes = (m_dataBufferSize + 1) & ~1;

String wireString =

String::createUninitialized(stringSizeBytes / 2, destination);

+ LOG(ERROR) << "wire string at " << ((void*)wireString.impl()) << ", buffer at " << ((void*)destination);

memcpy(destination, m_dataBuffer.get(), m_dataBufferSize);

if (stringSizeBytes > m_dataBufferSize)

reinterpret_cast<char*>(destination)[stringSizeBytes - 1] = '\0';