Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2509203003: MIPS[64]: Disable Add/Shl to Lsa optimization if operand is immediate (Closed)

Created:
4 years, 1 month ago by ivica.bogosavljevic
Modified:
4 years ago
Reviewers:
predrag.rudic, ilija.pavlovic, miran.karic, miran.karic, Ilija.Pavlovic1, dusan.simicic, ilija.pavlovic
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Disable Add/Shl to Lsa optimization if operand is immediate Add/Shl to Lsa optimization doesn't yield any performance increase in case one of the operand is immediate, because Lsa cannot use the immediate so we use an extra instruction to load the immediate to register. On MIPSR2 and less this optimization leads to performance degradation, since Lsa is not supported on these architectures and it is emulated using Add/Shl which do support immediate as operand for Add. BUG= Committed: https://crrev.com/591a7ce05b6cbec052126b8b540b7176db455819 Cr-Commit-Position: refs/heads/master@{#41143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ivica.bogosavljevic
PTAL
4 years, 1 month ago (2016-11-17 15:24:54 UTC) #2
Ilija.Pavlovic1
lgtm
4 years, 1 month ago (2016-11-18 07:30:19 UTC) #4
miran.karic
lgtm
4 years, 1 month ago (2016-11-18 13:41:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509203003/1
4 years ago (2016-11-21 13:34:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-21 14:04:21 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-21 14:04:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/591a7ce05b6cbec052126b8b540b7176db455819
Cr-Commit-Position: refs/heads/master@{#41143}

Powered by Google App Engine
This is Rietveld 408576698