rAc: update android test

chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java

Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java
index ec58b3ee5d999aaf62624b8ca862662264c47316..c84a195c624da4631c57ea3569af2872b79d3a4c 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java
@@ -26,6 +26,7 @@ public class AutofillDialogControllerTest extends ChromiumTestShellTestBase {
     private static final long DIALOG_CALLBACK_DELAY_MILLISECONDS = 50;
     private static final String TEST_NAME = "Joe Doe";
     private static final String TEST_PHONE = "(415)123-4567";

[aruslan, 2013/10/01 01:51:17]

I'm sure you'd love it.
It was returning "unformatted" (aka, user-formatted) phone number because
(415)123-4567 is indeed invalid phone number.

Fix: "(415)413-0703" from http://www.fictionaltelecom.com/

[Evan Stade, 2013/10/01 02:00:36]

thanks for figuring it out! Funnily enough, I had that problem in my own unit
tests, but that was last week so I forgot it could be an issue.

+    private static final String TEST_PHONE_UNFORMATTED = "4151234567";

[Evan Stade, 2013/09/30 23:01:42]

As you can see, I tried (and failed) to update the android tests.

The desired behavior is that when filling a phone number into the page, there is
no formatting. See description of original bug for desired display behavior (it
depends on the data source, etc.).

[aruslan, 2013/09/30 23:56:05]

Looking into this.

[aruslan, 2013/10/01 01:51:17]

"4154130703"

     private static final String TEST_EMAIL = "email@server.com";
     private static final String TEST_CC_NUMBER = "4111111111111111";
     private static final String TEST_CC_CSC = "123";
@@ -39,6 +40,7 @@ public class AutofillDialogControllerTest extends ChromiumTestShellTestBase {
     private static final String TEST_BILLING_COUNTRY = "US";
     private static final String TEST_SHIPPING_NAME = "Mister Receiver";
     private static final String TEST_SHIPPING_PHONE = "+46 8 713 99 99";
+    private static final String TEST_SHIPPING_PHONE_UNFORMATTED = "4687139999";
     private static final String TEST_SHIPPING1 = "19 Farstaplan";
     private static final String TEST_SHIPPING2 = "Third floor";
     private static final String TEST_SHIPPING_CITY = "Farsta";
@@ -226,7 +228,7 @@ public class AutofillDialogControllerTest extends ChromiumTestShellTestBase {
     public void testRacTypeTel() throws InterruptedException, TimeoutException {
         verifyOneField(
                 "<input id=\"id\" autocomplete=\"tel\">",
-                TEST_SHIPPING_PHONE, "id", false, true, true);
+                TEST_SHIPPING_PHONE_UNFORMATTED, "id", false, true, true);
     }
 
     @SmallTest
@@ -234,7 +236,7 @@ public class AutofillDialogControllerTest extends ChromiumTestShellTestBase {
     public void testRacTypeBillingTel() throws InterruptedException, TimeoutException {
         verifyOneField(
                 "<input id=\"id\" autocomplete=\"billing tel\">",
-                TEST_PHONE, "id", true, false, true);
+                TEST_PHONE_UNFORMATTED, "id", true, false, true);
     }
 
     @SmallTest
@@ -242,7 +244,7 @@ public class AutofillDialogControllerTest extends ChromiumTestShellTestBase {
     public void testRacTypeShippingTel() throws InterruptedException, TimeoutException {
         verifyOneField(
                 "<input id=\"id\" autocomplete=\"shipping tel\">",
-                TEST_SHIPPING_PHONE, "id", false, true, true);
+                TEST_SHIPPING_PHONE_UNFORMATTED, "id", false, true, true);
     }
 
     @SmallTest
@@ -521,7 +523,7 @@ public class AutofillDialogControllerTest extends ChromiumTestShellTestBase {
 
             if (requestPhoneNumbers) {
                 assertEquals("billing tel did not match",
-                        TEST_PHONE, DOMUtils.getNodeValue(view, viewClient, "id-cc-tel"));
+                        TEST_PHONE_UNFORMATTED, DOMUtils.getNodeValue(view, viewClient, "id-cc-tel"));
             }
         }
 
@@ -549,12 +551,12 @@ public class AutofillDialogControllerTest extends ChromiumTestShellTestBase {
 
             if (requestPhoneNumbers) {
                 assertEquals("shipping tel did not match",
-                        TEST_SHIPPING_PHONE, DOMUtils.getNodeValue(view, viewClient, "id-h-tel"));
+                        TEST_SHIPPING_PHONE_UNFORMATTED, DOMUtils.getNodeValue(view, viewClient, "id-h-tel"));
 
                 // It is currently unspecified whether autocomplete="name" gives a SHIPPING or
                 // a BILLING phone. I'm assuming here that this is a shipping phone.
                 assertEquals("tel did not match",
-                        TEST_SHIPPING_PHONE, DOMUtils.getNodeValue(view, viewClient, "id-tel"));
+                        TEST_SHIPPING_PHONE_UNFORMATTED, DOMUtils.getNodeValue(view, viewClient, "id-tel"));
             }
         }
     }