third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl - Issue 2509193002: Correct the OffscreenCanvas.getContext API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl

Issue 2509193002: Correct the OffscreenCanvas.getContext API (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext.html ('K') | « third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl

diff --git a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl

index 5a0b95bc411e64ac1a2f7ec2ab0b41ceba785639..dbfa0504c3c0ef68494af4f15123b9fb3501c9a3 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl

+++ b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl

@@ -7,7 +7,8 @@

typedef (OffscreenCanvasRenderingContext2D or

WebGLRenderingContext or

WebGL2RenderingContext) OffscreenRenderingContext;

+enum OffscreenRenderingContextType { "2d", "webgl" };

Justin Novosad 2016/11/17 15:36:42 please add webgl2. Hmmm, and we need a test that

partial interface OffscreenCanvas {

- [CallWith=ScriptState, RaisesException, RuntimeEnabled=ExperimentalCanvasFeatures] OffscreenRenderingContext? getContext(DOMString contextId, optional CanvasContextCreationAttributes attributes);

+ [CallWith=ScriptState, RaisesException, RuntimeEnabled=ExperimentalCanvasFeatures] OffscreenRenderingContext? getContext(OffscreenRenderingContextType contextType, optional CanvasContextCreationAttributes attributes);

};