Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7466)

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

Issue 2509163004: [MD settings] content category policy (Closed)
Patch Set: main toggle and sub-setting toogle show controlled by icon; review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
diff --git a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
index 02b9ca2212ba0798c9bcd7d370ac678f350d2fac..d5a40964d658eaf740827f150d8cbb24a036d0ce 100644
--- a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
+++ b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
@@ -8,6 +8,17 @@
*/
/**
+ * The handler will send a police source that is similar, but not exactly the
+ * same as a ControlledBy value.
+ * @enum {string}
+ */
+var ContentSettingProvider = {
+ DEFAULT: 'default',
Dan Beam 2016/11/29 05:17:14 where is this ^ ever used?
dschuyler 2016/11/29 22:28:12 It's a holdover from a prior patch in this CL, bef
+ EXTENSION: 'extension',
+ PREFERENCE: 'preference',
+};
+
+/**
* @typedef {{embeddingOrigin: string,
* embeddingOriginForDisplay: string,
* incognito: boolean,
@@ -25,6 +36,12 @@ var SiteException;
var CategoryDefaultsPref;
/**
+ * @typedef {{setting: string,
+ * source: ContentSettingProvider}}
+ */
+var DefaultContentSetting;
+
+/**
* @typedef {{location: Array<SiteException>,
* notifications: Array<SiteException>}}
*/
@@ -96,7 +113,7 @@ cr.define('settings', function() {
/**
* Gets the default value for a site settings category.
* @param {string} contentType The name of the category to query.
- * @return {!Promise<string>} The string value of the default setting.
+ * @return {!Promise<!DefaultContentSetting>}
*/
getDefaultValueForContentType: function(contentType) {},

Powered by Google App Engine
This is Rietveld 408576698