[MD settings] content category policy

chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

Index: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
diff --git a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
index 02b9ca2212ba0798c9bcd7d370ac678f350d2fac..c337b64da5d9a96438cbf2c37918c13163e54cc3 100644
--- a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
+++ b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
@@ -8,6 +8,17 @@
  */
 
 /**
+ * The handler will send a police source that is similar, but not exactly the
+ * same as a ControlledBy value.
+ * @enum {string}
+ */
+var PolicySource = {

[Dan Beam, 2016/11/22 02:57:41]

this name doesn't make much sense.  policy is a specific thing, and extensions
nor preferences are a source of policy.  policy does *set* preferences often,
and it also can *install* an extension.

how about ContentSettingSource? or ContentSettingProvider?

[dschuyler, 2016/11/24 01:25:48]

Done.

+  DEFAULT: 'default',
+  EXTENSION: 'extension',
+  PREFERENCE: 'preference',
+};
+
+/**
  * @typedef {{embeddingOrigin: string,
  *            embeddingOriginForDisplay: string,
  *            incognito: boolean,
@@ -25,6 +36,12 @@ var SiteException;
 var CategoryDefaultsPref;
 
 /**
+ * @typedef {{setting: string,
+ *            source: PolicySource}}
+ */
+var ContentCategorySetting;

[Dan Beam, 2016/11/22 02:57:41]

can this be like ContentTypeDefault or ContentSettingDefault?  you're calling
getDefaultValueForContentType to get these

[dschuyler, 2016/11/24 01:25:48]

Done.

+
+/**
  * @typedef {{location: Array<SiteException>,
  *            notifications: Array<SiteException>}}
  */
@@ -96,7 +113,7 @@ cr.define('settings', function() {
     /**
      * Gets the default value for a site settings category.
      * @param {string} contentType The name of the category to query.
-     * @return {!Promise<string>} The string value of the default setting.
+     * @return {!Promise<!ContentCategorySetting>}
      */
     getDefaultValueForContentType: function(contentType) {},