Add Prerender type to NavigationType for nav timing 2

third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h

Index: third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h b/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
index 870af370ee1e9cb9c896147f4af8537c40688aef..bde5b567ddd8b931eac46cd94c207481ae0893ab 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
@@ -16,6 +16,13 @@ class CORE_EXPORT PerformanceNavigationTiming final
   DEFINE_WRAPPERTYPEINFO();
 
  public:
+  enum PerformanceNavigationType {
+    KTypeNavigate,
+    KTypeReload,
+    KTypeBackForward,
+    KTypePrerender

[kinuko, 2016/11/22 03:05:22]

'PerformanceNavigationType' sounds a little odd (we have 'navigation timing' in
performance API but don't have terms like 'performance navigation'), and we're
already inside the PerformanceNavigationTiming class, maybe the enum name could
be a little shorter

enum type names look weird, remove the leading K (like other enums in blink) or
use lower k (a la
https://google.github.io/styleguide/cppguide.html#Enumerator_Names)

Also let's use enum class so that we can use shorter enum names.  So it'd result
something like

enum class NavigationType {
  Navigate,
  Reload,
  BackForward,
  Prerender
};

[sunjian, 2016/11/22 22:04:42]

Done.

+  };

[Yoav Weiss, 2016/11/22 10:46:32]

A nearly identical enum is already defined (but not really used anywhere AFAICT)
in PerformanceNavigation.h
Can we at least get rid of one of them?

Also, is the "K" prefix part of the new style guide? Not an often used
convention in Blink code

[sunjian, 2016/11/22 22:04:42]

Agree. That's why i named this new enum differently than the existing one
and borrowed the old one's definition a little bit. I am not sure whether we
should
create a new one with the prerender type and then replace the old one with the
new one.
It sounds pretty messy to me cause nav timing 1 apparently doesn't have a
prerender type.

+
   PerformanceNavigationTiming(double timeOrigin,
                               double unloadEventStart,
                               double unloadEventEnd,
@@ -26,7 +33,7 @@ class CORE_EXPORT PerformanceNavigationTiming final
                               double domContentLoadedEventStart,
                               double domContentLoadedEventEnd,
                               double domComplete,
-                              NavigationType,
+                              PerformanceNavigationType,
                               double redirectStart,
                               double redirectEnd,
                               double fetchStart,
@@ -74,7 +81,7 @@ class CORE_EXPORT PerformanceNavigationTiming final
   double m_domContentLoadedEventStart;
   double m_domContentLoadedEventEnd;
   double m_domComplete;
-  NavigationType m_type;
+  PerformanceNavigationType m_type;
   double m_redirectStart;
   double m_redirectEnd;
   double m_fetchStart;