Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp

Issue 2509143002: Add Prerender type to NavigationType for nav timing 2 (Closed)
Patch Set: added comments in NT1 implementation files Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp b/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
index 080836e01b62a151347b338d2609ebba07393c95..492bd87b424a99c19b88c1b77a917aa4292f175d 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
@@ -121,16 +121,17 @@ double PerformanceNavigationTiming::loadEventEnd() const {
}
AtomicString PerformanceNavigationTiming::type() const {
- // TODO(sunjian) Right now NavigationType doesn't seem to have a Prerender
- // type yet, need to look into this crbug/663217
switch (m_type) {
- case NavigationTypeReload:
+ case NavigationType::Reload:
return "reload";
- case NavigationTypeBackForward:
+ case NavigationType::BackForward:
return "back_forward";
- default:
+ case NavigationType::Prerender:
+ return "prerender";
+ case NavigationType::Navigate:
return "navigate";
}
+ NOTREACHED();
kinuko 2016/11/30 05:29:29 nit- still need to return something here to get it
sunjian 2016/11/30 19:15:47 Done.
}
unsigned short PerformanceNavigationTiming::redirectCount() const {

Powered by Google App Engine
This is Rietveld 408576698