core/fpdfapi/parser/cpdf_syntax_parser.h - Issue 2509123002: Make CPDF_Object subclass constructors intern strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_syntax_parser.h

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)

Patch Set: Nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_syntax_parser.h

diff --git a/core/fpdfapi/parser/cpdf_syntax_parser.h b/core/fpdfapi/parser/cpdf_syntax_parser.h

index 29eb3e18968c8b25afb00afe41332f805f7dc4de..094872ab7099819bf6c340ccb7f7acfb1d2c9e28 100644

--- a/core/fpdfapi/parser/cpdf_syntax_parser.h

+++ b/core/fpdfapi/parser/cpdf_syntax_parser.h

@@ -79,7 +79,6 @@ class CPDF_SyntaxParser {

uint32_t objnum,

uint32_t gennum);

- CFX_ByteString MaybeIntern(const CFX_ByteString& str);

inline bool CheckPosition(FX_FILESIZE pos) {

return m_BufOffset >= pos ||

static_cast<FX_FILESIZE>(m_BufOffset + m_BufSize) <= pos;

« no previous file with comments | « core/fpdfapi/parser/cpdf_string.cpp ('k') | core/fpdfapi/parser/cpdf_syntax_parser.cpp » ('j') | no next file with comments »