core/fpdfapi/parser/cfdf_document.cpp - Issue 2509123002: Make CPDF_Object subclass constructors intern strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cfdf_document.cpp

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)

Patch Set: Nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cfdf_document.cpp

diff --git a/core/fpdfapi/parser/cfdf_document.cpp b/core/fpdfapi/parser/cfdf_document.cpp

index 96ed4ae6eb3e6e10675a686ac41b9634a8796808..0bfcb65df9cbe1a8949c6f1dd71e26c966ce0138 100644

--- a/core/fpdfapi/parser/cfdf_document.cpp

+++ b/core/fpdfapi/parser/cfdf_document.cpp

@@ -24,8 +24,7 @@ CFDF_Document::~CFDF_Document() {

CFDF_Document* CFDF_Document::CreateNewDoc() {

CFDF_Document* pDoc = new CFDF_Document;

- pDoc->m_pRootDict =

- pDoc->NewIndirect<CPDF_Dictionary>(pDoc->GetByteStringPool());

+ pDoc->m_pRootDict = pDoc->NewIndirect<CPDF_Dictionary>();

pDoc->m_pRootDict->SetFor("FDF",

new CPDF_Dictionary(pDoc->GetByteStringPool()));

return pDoc;

« no previous file with comments | « core/fpdfapi/page/cpdf_streamparser.cpp ('k') | core/fpdfapi/parser/cpdf_array.h » ('j') | no next file with comments »