core/fpdfdoc/cpdf_interform.cpp - Issue 2509123002: Make CPDF_Object subclass constructors intern strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_interform.cpp

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)

Patch Set: finish Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_interform.cpp

diff --git a/core/fpdfdoc/cpdf_interform.cpp b/core/fpdfdoc/cpdf_interform.cpp

index c991598a2228faaf800081cfcb2835153b2bf9a5..f541d7087c7f836067677213dbd1c285d13d37b0 100644

--- a/core/fpdfdoc/cpdf_interform.cpp

+++ b/core/fpdfdoc/cpdf_interform.cpp

@@ -59,8 +59,7 @@ void InitDict(CPDF_Dictionary*& pFormDict, CPDF_Document* pDocument) {

return;

if (!pFormDict) {

- pFormDict =

- pDocument->NewIndirect<CPDF_Dictionary>(pDocument->GetByteStringPool());

+ pFormDict = pDocument->NewIndirect<CPDF_Dictionary>();

pDocument->GetRoot()->SetReferenceFor("AcroForm", pDocument,

pFormDict->GetObjNum());

}