Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2358)

Unified Diff: core/fpdfapi/parser/cpdf_object_unittest.cpp

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/parser/cpdf_object_unittest.cpp
diff --git a/core/fpdfapi/parser/cpdf_object_unittest.cpp b/core/fpdfapi/parser/cpdf_object_unittest.cpp
index c34128460288ea3ab203c6238eb55abc528f7ee8..385bb216317bfb0b73cf4bddf7618dcc7918416d 100644
--- a/core/fpdfapi/parser/cpdf_object_unittest.cpp
+++ b/core/fpdfapi/parser/cpdf_object_unittest.cpp
@@ -56,7 +56,7 @@ class PDFObjectsTest : public testing::Test {
CPDF_String* str_reg_obj = new CPDF_String(L"A simple test");
CPDF_String* str_spec_obj = new CPDF_String(L"\t\n");
// Name object.
- CPDF_Name* name_obj = new CPDF_Name("space");
+ CPDF_Name* name_obj = new CPDF_Name(nullptr, "space");
// Array object.
m_ArrayObj = new CPDF_Array;
m_ArrayObj->InsertNewAt<CPDF_Number>(0, 8902);
@@ -711,7 +711,7 @@ TEST(PDFArrayTest, AddReferenceAndGetObjectAt) {
CPDF_Number* int_obj = new CPDF_Number(-1234);
CPDF_Number* float_obj = new CPDF_Number(2345.089f);
CPDF_String* str_obj = new CPDF_String("Adsfdsf 343434 %&&*\n", false);
- CPDF_Name* name_obj = new CPDF_Name("Title:");
+ CPDF_Name* name_obj = new CPDF_Name(nullptr, "Title:");
CPDF_Null* null_obj = new CPDF_Null();
CPDF_Object* indirect_objs[] = {boolean_obj, int_obj, float_obj,
str_obj, name_obj, null_obj};

Powered by Google App Engine
This is Rietveld 408576698